Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2390553002: Remove NO_LAZY_SWEEP_SANITIZE_ADDRESS (Closed)

Created:
4 years, 2 months ago by haraken
Modified:
4 years, 2 months ago
Reviewers:
keishi, Nico
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NO_LAZY_SWEEP_SANITIZE_ADDRESS Now that Oilpan is on, the macro is no longer needed. BUG= Committed: https://crrev.com/e4ca6460f9219712941eb973192c65680138c71c Cr-Commit-Position: refs/heads/master@{#422408}

Patch Set 1 #

Total comments: 1

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M third_party/WebKit/Source/platform/Timer.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/AddressSanitizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
haraken
PTAL
4 years, 2 months ago (2016-10-03 02:46:55 UTC) #2
Nico
https://codereview.chromium.org/2390553002/diff/1/third_party/WebKit/Source/platform/Timer.h File third_party/WebKit/Source/platform/Timer.h (left): https://codereview.chromium.org/2390553002/diff/1/third_party/WebKit/Source/platform/Timer.h#oldcode91 third_party/WebKit/Source/platform/Timer.h:91: NO_LAZY_SWEEP_SANITIZE_ADDRESS Can this be deleted completely or should this ...
4 years, 2 months ago (2016-10-03 02:49:35 UTC) #3
haraken
On 2016/10/03 02:49:35, Nico (mostly away until Oct 3) wrote: > https://codereview.chromium.org/2390553002/diff/1/third_party/WebKit/Source/platform/Timer.h > File third_party/WebKit/Source/platform/Timer.h ...
4 years, 2 months ago (2016-10-03 04:18:45 UTC) #4
Nico
lgtm
4 years, 2 months ago (2016-10-03 11:52:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390553002/20001
4 years, 2 months ago (2016-10-03 11:53:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 13:12:43 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 13:14:34 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e4ca6460f9219712941eb973192c65680138c71c
Cr-Commit-Position: refs/heads/master@{#422408}

Powered by Google App Engine
This is Rietveld 408576698