Tidy up ssl_platform_key_android_unittest.cc.

Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

Also check in client_root_ca.pem so the inputs are all available.

BUG=630150
Committed: https://crrev.com/7d92d2268bd7df1cfcf1a021a480eed851f52fa7
Cr-Commit-Position: refs/heads/master@{#423029}

[davidben, 2016-10-01 15:34:56]

Description was changed from

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for some work
along the way to preparing our ECDSA client certs logic for TLS 1.3.

BUG=630150
==========

to

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

BUG=630150
==========

[davidben, 2016-10-01 15:35:21]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 15:35:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 17:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 17:36:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2016-10-01 17:42:18]

davidben@chromium.org changed reviewers:
+ mattm@chromium.org

[mattm, 2016-10-03 22:51:04]

lgtm

https://codereview.chromium.org/2390493002/diff/1/net/data/ssl/scripts/genera...
File net/data/ssl/scripts/generate-client-certificates.sh (right):

https://codereview.chromium.org/2390493002/diff/1/net/data/ssl/scripts/genera...
net/data/ssl/scripts/generate-client-certificates.sh:201: -passout pass:chrome
I wonder why this script generates the .p12 files but doesn't actually save them
to certificates and nothing uses them..

https://codereview.chromium.org/2390493002/diff/1/net/data/ssl/scripts/genera...
net/data/ssl/scripts/generate-client-certificates.sh:203: echo Package the
client certs for unit tests
While you're here.. would you mind making this copy the root cert (C.pem) into
certificates also? Would be helpful for manual testing client cert stuff. (I ran
into this on the client cert bug I was working on recently, had to regenerate
the certs for my testing since the root wasn't checked in.)

[davidben, 2016-10-04 18:56:32]

https://codereview.chromium.org/2390493002/diff/1/net/data/ssl/scripts/genera...
File net/data/ssl/scripts/generate-client-certificates.sh (right):

https://codereview.chromium.org/2390493002/diff/1/net/data/ssl/scripts/genera...
net/data/ssl/scripts/generate-client-certificates.sh:201: -passout pass:chrome
On 2016/10/03 22:51:04, mattm wrote:
> I wonder why this script generates the .p12 files but doesn't actually save
them
> to certificates and nothing uses them..

No idea. I've found them useful at times, but I've just run the script anew each
time.

https://codereview.chromium.org/2390493002/diff/1/net/data/ssl/scripts/genera...
net/data/ssl/scripts/generate-client-certificates.sh:203: echo Package the
client certs for unit tests
On 2016/10/03 22:51:04, mattm wrote:
> While you're here.. would you mind making this copy the root cert (C.pem) into
> certificates also? Would be helpful for manual testing client cert stuff. (I
ran
> into this on the client cert bug I was working on recently, had to regenerate
> the certs for my testing since the root wasn't checked in.)

Done.

[davidben, 2016-10-04 18:57:00]

Description was changed from

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

BUG=630150
==========

to

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

Also check in client_root_ca.pem so the inputs are all available.

BUG=630150
==========

[davidben, 2016-10-04 19:01:23]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-10-04 19:01:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2390493002/#ps60001
(title: "add to README")

[commit-bot: I haz the power, 2016-10-04 19:01:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:26:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2016-10-04 23:56:22]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-10-04 23:56:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2390493002/#ps80001
(title: "Regenerate CrOS data")

[commit-bot: I haz the power, 2016-10-04 23:56:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 00:54:49]

Description was changed from

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

Also check in client_root_ca.pem so the inputs are all available.

BUG=630150
==========

to

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

Also check in client_root_ca.pem so the inputs are all available.

BUG=630150
==========

[commit-bot: I haz the power, 2016-10-05 00:54:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-05 00:57:56]

Description was changed from

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

Also check in client_root_ca.pem so the inputs are all available.

BUG=630150
==========

to

==========
Tidy up ssl_platform_key_android_unittest.cc.

Use the same test files as other client cert tests. While I'm here, use
the new BoringSSL scopers. This is done in preparation for to make
our ECDSA client certs logic for TLS 1.3. (Having certificates with the
keys will be convenient)

Also check in client_root_ca.pem so the inputs are all available.

BUG=630150

Committed: https://crrev.com/7d92d2268bd7df1cfcf1a021a480eed851f52fa7
Cr-Commit-Position: refs/heads/master@{#423029}
==========

[commit-bot: I haz the power, 2016-10-05 00:57:57]

Patchset 5 (id:??) landed as
https://crrev.com/7d92d2268bd7df1cfcf1a021a480eed851f52fa7
Cr-Commit-Position: refs/heads/master@{#423029}