Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 23903040: Fix memory leak in PrefMetricsService (Closed)

Created:
7 years, 3 months ago by battre
Modified:
7 years, 3 months ago
Reviewers:
markusheintz_, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, bbudge
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M base/values.h View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_metrics_service.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
battre
Markus, could you please review this CL? Thanks, Dominic
7 years, 3 months ago (2013-09-11 07:20:39 UTC) #1
battre
CC'ing Pam (FYI)
7 years, 3 months ago (2013-09-11 07:31:01 UTC) #2
Pam (message me for reviews)
Ah, thanks. I should have checked the ownership model.
7 years, 3 months ago (2013-09-11 08:01:40 UTC) #3
markusheintz_
On 2013/09/11 08:01:40, Pam (also PM for reviews) wrote: > Ah, thanks. I should have ...
7 years, 3 months ago (2013-09-11 08:20:17 UTC) #4
battre
Hi Nico, I am going to TBR you on this one for OWNER's approval on ...
7 years, 3 months ago (2013-09-11 08:41:47 UTC) #5
battre
Committed patchset #1 manually as r222500 (presubmit successful).
7 years, 3 months ago (2013-09-11 12:06:10 UTC) #6
Nico
7 years, 3 months ago (2013-09-11 18:22:25 UTC) #7
Message was sent while issue was closed.
base/ lgtm

Powered by Google App Engine
This is Rietveld 408576698