base/values.cc - Issue 23903040: Fix memory leak in PrefMetricsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.cc

Issue 23903040: Fix memory leak in PrefMetricsService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.cc

diff --git a/base/values.cc b/base/values.cc

index 76e73a01935bc417e937c9b3d8e634624a7d9a9f..2d3984e0d4247ddb2b82aed3758771fa19bf8e31 100644

--- a/base/values.cc

+++ b/base/values.cc

@@ -755,7 +755,7 @@ bool DictionaryValue::RemoveWithoutPathExpansion(const std::string& key,

return true;

}

-DictionaryValue* DictionaryValue::DeepCopyWithoutEmptyChildren() {

+DictionaryValue* DictionaryValue::DeepCopyWithoutEmptyChildren() const {

Value* copy = CopyWithoutEmptyChildren(this);

return copy ? static_cast<DictionaryValue*>(copy) : new DictionaryValue;

}

« no previous file with comments | « base/values.h ('k') | chrome/browser/prefs/pref_metrics_service.cc » ('j') | no next file with comments »