Issue 23903018: Revert 221579 "Files.app: Let the PreviewPanel class control the..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23903018: Revert 221579 "Files.app: Let the PreviewPanel class control the..." (Closed)

Created:
7 years, 3 months ago by hirono

Modified:
7 years, 3 months ago

Reviewers:
hirono

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 221579 "Files.app: Let the PreviewPanel class control the..." > Files.app: Let the PreviewPanel class control the visibility of the preview panel. > > Originally, PreviewPanel is not used from any code. > This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel. > > BUG=284215 > TEST=manually > R=yoshiki@chromium.org > > Review URL: https://codereview.chromium.org/23464030 TBR=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221613

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -51 lines)			Patch
M	trunk/src/chrome/browser/resources/file_manager/js/file_manager.js	View	7 chunks	+22 lines, -33 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/file_manager/js/file_selection.js	View	7 chunks	+83 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/file_manager/js/main_scripts.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/resources/file_manager/js/ui/preview_panel.js	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/file_manager/main.html	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r221613.