Files.app: Let the PreviewPanel class control the visibility of the preview panel.

Files.app: Let the PreviewPanel class control the visibility of the preview panel.

Originally, PreviewPanel is not used from any code.
This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel.

BUG=284215
TEST=manually
R=yoshiki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221579

[hirono, 2013-09-04 13:27:57]

Could you take a look the CL?
Thank you very much!

[yoshiki, 2013-09-04 13:45:02]

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:853:
PreviewPanel.VisibilityType.ALWAYS :
ALWAYS_VISIBLE or FORCE_VISIBLE is better, instead of ALWAYS?

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:1539:
this.selectionHandler_.previewPanel_.visibilityType =
We can't access this.selectionHandler_.previewPanel_ directly, since it is
private variable. Couldn't you use this.previewPanel_?

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:1540:
PreviewPanel.VisibilityType.HIDDEN;
ALWAYS_HIDDEN or FORCE_HIDDEN?

[hirono, 2013-09-05 02:26:19]

Thanks!

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:853:
PreviewPanel.VisibilityType.ALWAYS :
On 2013/09/04 13:45:02, yoshiki wrote:
> ALWAYS_VISIBLE or FORCE_VISIBLE is better, instead of ALWAYS?

Done.

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:1539:
this.selectionHandler_.previewPanel_.visibilityType =
On 2013/09/04 13:45:02, yoshiki wrote:
> We can't access this.selectionHandler_.previewPanel_ directly, since it is
> private variable. Couldn't you use this.previewPanel_? 

Done.

https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/file_manager.js:1540:
PreviewPanel.VisibilityType.HIDDEN;
On 2013/09/04 13:45:02, yoshiki wrote:
> ALWAYS_HIDDEN or FORCE_HIDDEN?

Done.

[hirono, 2013-09-06 01:49:30]

On 2013/09/05 02:26:19, hirono wrote:
> Thanks!
> 
>
https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
> File chrome/browser/resources/file_manager/js/file_manager.js (right):
> 
>
https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
> chrome/browser/resources/file_manager/js/file_manager.js:853:
> PreviewPanel.VisibilityType.ALWAYS :
> On 2013/09/04 13:45:02, yoshiki wrote:
> > ALWAYS_VISIBLE or FORCE_VISIBLE is better, instead of ALWAYS?
> 
> Done.
> 
>
https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
> chrome/browser/resources/file_manager/js/file_manager.js:1539:
> this.selectionHandler_.previewPanel_.visibilityType =
> On 2013/09/04 13:45:02, yoshiki wrote:
> > We can't access this.selectionHandler_.previewPanel_ directly, since it is
> > private variable. Couldn't you use this.previewPanel_? 
> 
> Done.
> 
>
https://codereview.chromium.org/23464030/diff/1/chrome/browser/resources/file...
> chrome/browser/resources/file_manager/js/file_manager.js:1540:
> PreviewPanel.VisibilityType.HIDDEN;
> On 2013/09/04 13:45:02, yoshiki wrote:
> > ALWAYS_HIDDEN or FORCE_HIDDEN?
> 
> Done.

@yoshiki-san - Ping. Thanks!

[yoshiki, 2013-09-06 02:23:14]

lgtm

[commit-bot: I haz the power, 2013-09-06 03:12:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/23464030/6001

[hirono, 2013-09-06 05:21:27]

Committed patchset #3 manually as r221579 (presubmit successful).