Issue 23903014: DOMParser.parseFromString() should support creating HTML Document with mimetype text/html

Issue 23903014: DOMParser.parseFromString() should support creating HTML Document with mimetype text/html (Closed)

Created:
7 years, 3 months ago by vivekg_samsung

Modified:
7 years, 3 months ago

Reviewers:
tkent, abarth-chromium, vivekg__, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

DOMParser.parseFromString() should support creating HTML Document with mimetype text/html The specification http://domparsing.spec.whatwg.org/#the-domparser-interface for DOMParser.parseFromString() allows the document creation if the mimeType is one of the supported types: ["text/html", "text/xml", "application/xml", "application/xhtml+xml", "image/svg+xml"] Also script elements get marked unexecutable and the contents of noscript get parsed as markup. R=tkent, abarth, eseidel BUG=265379 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157322

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch for landing! #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -2 lines)			Patch
A	LayoutTests/fast/dom/domparser-parsefromstring-mimetype-support.html	View	1	1 chunk	+151 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/domparser-parsefromstring-mimetype-support-expected.txt	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	Source/core/xml/DOMParser.cpp	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM https://codereview.chromium.org/23903014/diff/1/Source/core/xml/DOMParser.cpp File Source/core/xml/DOMParser.cpp (right): https://codereview.chromium.org/23903014/diff/1/Source/core/xml/DOMParser.cpp#newcode30 Source/core/xml/DOMParser.cpp:30: if (!(DOMImplementation::isXMLMIMEType(contentType) || contentType == "text/html")) Can you ...

7 years, 3 months ago (2013-09-05 17:25:31 UTC) #2

eseidel

This test is fine, but please add another which does something like: shouldSupport("text/html", "<html>"); shouldSupport("image/svg+xml", ...

7 years, 3 months ago (2013-09-05 17:26:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/23903014/7001

7 years, 3 months ago (2013-09-05 20:07:48 UTC) #5

Message was sent while issue was closed.

Change committed as 157322

Expand Messages | Collapse Messages