Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2390233004: Remove old FIXME about not checking needsLayout, switch to a CHECK (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old FIXME about not checking needsLayout, switch to a CHECK BUG=264211 Committed: https://crrev.com/38bb6e0caccda913c53ec92a518047a0a18ded70 Cr-Commit-Position: refs/heads/master@{#423274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pdr.
4 years, 2 months ago (2016-10-04 22:04:38 UTC) #3
fs
lgtm
4 years, 2 months ago (2016-10-05 08:48:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390233004/1
4 years, 2 months ago (2016-10-05 18:46:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 20:30:34 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 20:32:48 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/38bb6e0caccda913c53ec92a518047a0a18ded70
Cr-Commit-Position: refs/heads/master@{#423274}

Powered by Google App Engine
This is Rietveld 408576698