Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

Issue 2390233004: Remove old FIXME about not checking needsLayout, switch to a CHECK (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
index 3a8fd042b940d86f6e1127148d54e0e258a0f0d6..39dcb44ac7b99fe9d12ba963cd0675d091b8af0e 100644
--- a/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
@@ -174,10 +174,7 @@ TextRun SVGInlineTextBox::constructTextRun(
const ComputedStyle& style,
const SVGTextFragment& fragment) const {
LineLayoutText text = getLineLayoutItem();
-
- // FIXME(crbug.com/264211): This should not be necessary but can occur if we
- // layout during layout. Remove this when 264211 is fixed.
- RELEASE_ASSERT(!text.needsLayout());
+ CHECK(!text.needsLayout());
TextRun run(
static_cast<const LChar*>(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698