Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2390203002: Use AtomicString instead of StringImpl* in PropertyHandle (Closed)

Created:
4 years, 2 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use AtomicString instead of StringImpl* in PropertyHandle This patch avoids using raw pointers to AtomicString contents for animation PropertyHandles. By making the AtomicString class a member all the necessary reference counting occurs. BUG=652127 Committed: https://crrev.com/71dd575dd664dcfa639dab8e9a1e469084df2d40 Cr-Commit-Position: refs/heads/master@{#422731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/animations/custom-property-animation-crash.html View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyHandle.h View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyHandle.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
alancutter (OOO until 2018)
4 years, 2 months ago (2016-10-04 06:14:44 UTC) #2
Eric Willigers
lgtm
4 years, 2 months ago (2016-10-04 06:17:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390203002/1
4 years, 2 months ago (2016-10-04 06:18:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 07:47:06 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 07:49:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71dd575dd664dcfa639dab8e9a1e469084df2d40
Cr-Commit-Position: refs/heads/master@{#422731}

Powered by Google App Engine
This is Rietveld 408576698