Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/LayoutTests/animations/custom-property-animation-crash.html

Issue 2390203002: Use AtomicString instead of StringImpl* in PropertyHandle (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/PropertyHandle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <script src="../resources/testharness.js"></script>
2 <script src="../resources/testharnessreport.js"></script>
3 <div id="target"></div>
4 <script>
5 promise_test(() => {
6 return new Promise(resolve => {
7 target.animate([
8 {'resize':'none'},
9 {'resize':'none'},
10 ], {
11 duration: 1000,
12 delay: 100,
13 });
14 target.animate([
15 {'--custom-property-name':'custom-value'},
16 {'--custom-property-name':'custom-value'},
17 ], 1);
18 // This specific combination of async behaviour is required to trigger the c rash,
19 // creating functions here prevents the crash. This is probably due to V8 GC
20 // implementation details.
21 setInterval(gc);
22 setTimeout(resolve);
23 });
24 }, 'Do not crash in ASAN when using custom properties in element.animate()');
25 </script>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/PropertyHandle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698