Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 23902007: [NaCl SDK] Porting the "Getting Started" tutorial to ReST. (Closed)

Created:
7 years, 3 months ago by binji
Modified:
7 years, 3 months ago
Reviewers:
eliben
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Porting the "Getting Started" tutorial to ReST. NOTE: this is just porting to ReST, I haven't updated anything to PNaCl yet. BUG=none R=eliben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221282

Patch Set 1 #

Total comments: 18

Patch Set 2 : fixes #

Patch Set 3 : Add dummy ReST files (to silence warnings) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -5 lines) Patch
A native_client_sdk/src/doc/devguide/coding/message-system.rst View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/coding/progress-events.rst View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A native_client_sdk/src/doc/devguide/devcycle/debugging.rst View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/devcycle/running.rst View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/devguide/tutorial.rst View 1 1 chunk +478 lines, -4 lines 0 comments Download
M native_client_sdk/src/doc/index.rst View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
7 years, 3 months ago (2013-09-04 18:52:04 UTC) #1
eliben
https://codereview.chromium.org/23902007/diff/1/native_client_sdk/src/doc/devguide/tutorial.rst File native_client_sdk/src/doc/devguide/tutorial.rst (right): https://codereview.chromium.org/23902007/diff/1/native_client_sdk/src/doc/devguide/tutorial.rst#newcode5 native_client_sdk/src/doc/devguide/tutorial.rst:5: ######################## These should be the same length as the ...
7 years, 3 months ago (2013-09-04 20:00:52 UTC) #2
binji
https://codereview.chromium.org/23902007/diff/1/native_client_sdk/src/doc/devguide/tutorial.rst File native_client_sdk/src/doc/devguide/tutorial.rst (right): https://codereview.chromium.org/23902007/diff/1/native_client_sdk/src/doc/devguide/tutorial.rst#newcode5 native_client_sdk/src/doc/devguide/tutorial.rst:5: ######################## On 2013/09/04 20:00:52, eliben wrote: > These should ...
7 years, 3 months ago (2013-09-04 20:49:40 UTC) #3
eliben
On 2013/09/04 20:49:40, binji wrote: > https://codereview.chromium.org/23902007/diff/1/native_client_sdk/src/doc/devguide/tutorial.rst > File native_client_sdk/src/doc/devguide/tutorial.rst (right): > > https://codereview.chromium.org/23902007/diff/1/native_client_sdk/src/doc/devguide/tutorial.rst#newcode5 > ...
7 years, 3 months ago (2013-09-04 20:59:06 UTC) #4
eliben
lgtm
7 years, 3 months ago (2013-09-04 20:59:12 UTC) #5
binji
7 years, 3 months ago (2013-09-04 22:36:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r221282 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698