Log app_shell warnings on loading apps

Log app_shell warnings on loading apps

Extension warnings should be logged somewhere, since we don't have a
UI for them like the Extensions UI's "developer mode".

R=steel@chromium.org
BUG=652006
Committed: https://crrev.com/6f456fb7856dc567afa9acb31c51cf81793677f0
Cr-Commit-Position: refs/heads/master@{#423473}

[michaelpg, 2016-10-04 01:39:50]

WDYT? See example output at https://crbug.com/652006#c2

[Rahul Chaturvedi, 2016-10-04 01:47:22]

lgtm

[michaelpg, 2016-10-04 02:19:15]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-10-04 02:19:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 02:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 02:49:08]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[michaelpg, 2016-10-04 05:31:54]

o.O

i look forward to debugging the compile issue with windows string types,
buuuuut.... i was not aware we compiled app_shell_lib for windows.

[Rahul Chaturvedi, 2016-10-04 05:59:27]

Windows uses wide strings for holding the filename value, hence usually any code
which uses file path values fails on Windows.

Even though we shouldn't be compiling on Windows, let us not remove the build
just yet. We should be able to work around this using LOG(WARNING) << "message"
<< path, instead of the + operator for std::string and FilePath.value().

See: https://cs.chromium.org/chromium/src/base/files/file_path.h?l=152

[michaelpg, 2016-10-06 07:41:50]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-10-06 07:41:50]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org
Link to the patchset: https://codereview.chromium.org/2390073002/#ps20001
(title: "sigh")

[commit-bot: I haz the power, 2016-10-06 07:42:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 08:10:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 08:12:02]

Description was changed from

==========
Log app_shell warnings on loading apps

Extension warnings should be logged somewhere, since we don't have a
UI for them like the Extensions UI's "developer mode".

R=steel@chromium.org
BUG=652006
==========

to

==========
Log app_shell warnings on loading apps

Extension warnings should be logged somewhere, since we don't have a
UI for them like the Extensions UI's "developer mode".

R=steel@chromium.org
BUG=652006

Committed: https://crrev.com/6f456fb7856dc567afa9acb31c51cf81793677f0
Cr-Commit-Position: refs/heads/master@{#423473}
==========

[commit-bot: I haz the power, 2016-10-06 08:12:03]

Patchset 2 (id:??) landed as
https://crrev.com/6f456fb7856dc567afa9acb31c51cf81793677f0
Cr-Commit-Position: refs/heads/master@{#423473}