Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issue 2390073002: Log app_shell warnings on loading apps (Closed)

Created:
4 years, 2 months ago by michaelpg
Modified:
4 years, 2 months ago
Reviewers:
Rahul Chaturvedi
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log app_shell warnings on loading apps Extension warnings should be logged somewhere, since we don't have a UI for them like the Extensions UI's "developer mode". R=steel@chromium.org BUG=652006 Committed: https://crrev.com/6f456fb7856dc567afa9acb31c51cf81793677f0 Cr-Commit-Position: refs/heads/master@{#423473}

Patch Set 1 #

Patch Set 2 : sigh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M extensions/shell/browser/shell_extension_system.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
michaelpg
WDYT? See example output at https://crbug.com/652006#c2
4 years, 2 months ago (2016-10-04 01:39:50 UTC) #1
Rahul Chaturvedi
lgtm
4 years, 2 months ago (2016-10-04 01:47:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390073002/1
4 years, 2 months ago (2016-10-04 02:19:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/269129)
4 years, 2 months ago (2016-10-04 02:49:08 UTC) #6
michaelpg
o.O i look forward to debugging the compile issue with windows string types, buuuuut.... i ...
4 years, 2 months ago (2016-10-04 05:31:54 UTC) #7
Rahul Chaturvedi
Windows uses wide strings for holding the filename value, hence usually any code which uses ...
4 years, 2 months ago (2016-10-04 05:59:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390073002/20001
4 years, 2 months ago (2016-10-06 07:42:02 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 08:10:42 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 08:12:03 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f456fb7856dc567afa9acb31c51cf81793677f0
Cr-Commit-Position: refs/heads/master@{#423473}

Powered by Google App Engine
This is Rietveld 408576698