Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3116)

Unified Diff: extensions/shell/browser/shell_extension_system.cc

Issue 2390073002: Log app_shell warnings on loading apps (Closed)
Patch Set: sigh Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_extension_system.cc
diff --git a/extensions/shell/browser/shell_extension_system.cc b/extensions/shell/browser/shell_extension_system.cc
index 5656032a8de25121431ad714e06667d9a05ee988..df9c433e6ecbc8c809b2f3f3e261adc7a800c2ba 100644
--- a/extensions/shell/browser/shell_extension_system.cc
+++ b/extensions/shell/browser/shell_extension_system.cc
@@ -56,6 +56,13 @@ const Extension* ShellExtensionSystem::LoadApp(const base::FilePath& app_dir) {
return nullptr;
}
+ // Log warnings.
+ if (extension->install_warnings().size()) {
+ LOG(WARNING) << "Warnings loading extension at " << app_dir.value() << ":";
+ for (const auto& warning : extension->install_warnings())
+ LOG(WARNING) << warning.message;
+ }
+
// TODO(jamescook): We may want to do some of these things here:
// * Create a PermissionsUpdater.
// * Call PermissionsUpdater::GrantActivePermissions().
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698