Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 239003004: Enable AVX opt for Win builds (Closed)

Created:
6 years, 8 months ago by Johann
Modified:
6 years, 8 months ago
Reviewers:
Tom Finegan
CC:
chromium-reviews, fgalligan1
Visibility:
Public.

Description

Enable AVX opt for Win builds Target vs12 == Visual Studio 2013 during configure. This enables HAVE_AVX[2] Add MSVS flags for /arch:AVX via EnableEnhancedInstructionSet: 3 Conveniently added in recently: https://codereview.chromium.org/195283002 R=tomfinegan@chromium.org TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264025

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M generate_gypi.sh View 1 2 chunks +11 lines, -2 lines 0 comments Download
M libvpx_srcs_x86_64_intrinsics.gypi View 1 1 chunk +7 lines, -0 lines 0 comments Download
M libvpx_srcs_x86_intrinsics.gypi View 1 1 chunk +7 lines, -0 lines 0 comments Download
M source/config/win/ia32/vpx_config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/win/ia32/vpx_config.asm View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/win/ia32/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/win/x64/vpx_config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/win/x64/vpx_config.asm View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/win/x64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johann
Please check out generate_gypi.sh
6 years, 8 months ago (2014-04-15 22:50:46 UTC) #1
Tom Finegan
lgtm
6 years, 8 months ago (2014-04-15 22:56:26 UTC) #2
Johann
6 years, 8 months ago (2014-04-15 23:01:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r264025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698