Add support for VCCLCompilerTool EnableEnhancedInstructionSet setting.

Add support for VCCLCompilerTool EnableEnhancedInstructionSet setting.

R=scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1865

[scottmg, 2014-03-11 16:32:58]

lgtm

https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
File test/win/compiler-flags/enable-enhanced-instruction-set.gyp (right):

https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
test/win/compiler-flags/enable-enhanced-instruction-set.gyp:50: },
Could you add an "unset" test too? It changed from 2010 (IA32) to 2012 (SSE2) by
default, which bit me.

https://codereview.chromium.org/195283002/diff/1/test/win/gyptest-cl-enable-e...
File test/win/gyptest-cl-enable-enhanced-instruction-set.py (right):

https://codereview.chromium.org/195283002/diff/1/test/win/gyptest-cl-enable-e...
test/win/gyptest-cl-enable-enhanced-instruction-set.py:17: test =
TestGyp.TestGyp(formats=['msvs', 'ninja'])
don't need formats= here

[grt (UTC plus 2), 2014-03-11 17:08:45]

https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
File test/win/compiler-flags/enable-enhanced-instruction-set.gyp (right):

https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
test/win/compiler-flags/enable-enhanced-instruction-set.gyp:50: },
On 2014/03/11 16:32:58, scottmg wrote:
> Could you add an "unset" test too? It changed from 2010 (IA32) to 2012 (SSE2)
by
> default, which bit me.

I thought about that. I would need to add a conditional in
gyptest-cl-enable-enhanced-instruction-set.py based on the version of vs being
used. Is there a convenient way to do that?

[scottmg, 2014-03-11 17:15:19]

On 2014/03/11 17:08:45, grt wrote:
>
https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
> File test/win/compiler-flags/enable-enhanced-instruction-set.gyp (right):
> 
>
https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
> test/win/compiler-flags/enable-enhanced-instruction-set.gyp:50: },
> On 2014/03/11 16:32:58, scottmg wrote:
> > Could you add an "unset" test too? It changed from 2010 (IA32) to 2012
(SSE2)
> by
> > default, which bit me.
> 
> I thought about that. I would need to add a conditional in
> gyptest-cl-enable-enhanced-instruction-set.py based on the version of vs being
> used. Is there a convenient way to do that?

I think

int(os.environ.get('GYP_MSVS_VERSION', 0)) >= 2012

would work.

[grt (UTC plus 2), 2014-03-11 17:44:27]

On 2014/03/11 17:15:19, scottmg wrote:
> On 2014/03/11 17:08:45, grt wrote:
> >
>
https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
> > File test/win/compiler-flags/enable-enhanced-instruction-set.gyp (right):
> > 
> >
>
https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
> > test/win/compiler-flags/enable-enhanced-instruction-set.gyp:50: },
> > On 2014/03/11 16:32:58, scottmg wrote:
> > > Could you add an "unset" test too? It changed from 2010 (IA32) to 2012
> (SSE2)
> > by
> > > default, which bit me.
> > 
> > I thought about that. I would need to add a conditional in
> > gyptest-cl-enable-enhanced-instruction-set.py based on the version of vs
being
> > used. Is there a convenient way to do that?
> 
> I think
> 
> int(os.environ.get('GYP_MSVS_VERSION', 0)) >= 2012
> 
> would work.

I think that will only work if GYP_MSVS_VERSION is set by the tester rather than
if the version is auto-detected. TestGyp.py has a FindVisualStudioInstallation
func, but it doesn't appear to expose the version number of the discovered
devenv. Would you like me to add to TestGyp.py so that consumers can query for
the discovered version of VS?

[scottmg, 2014-03-11 17:52:49]

On 2014/03/11 17:44:27, grt wrote:
> On 2014/03/11 17:15:19, scottmg wrote:
> > On 2014/03/11 17:08:45, grt wrote:
> > >
> >
>
https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
> > > File test/win/compiler-flags/enable-enhanced-instruction-set.gyp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/195283002/diff/1/test/win/compiler-flags/enab...
> > > test/win/compiler-flags/enable-enhanced-instruction-set.gyp:50: },
> > > On 2014/03/11 16:32:58, scottmg wrote:
> > > > Could you add an "unset" test too? It changed from 2010 (IA32) to 2012
> > (SSE2)
> > > by
> > > > default, which bit me.
> > > 
> > > I thought about that. I would need to add a conditional in
> > > gyptest-cl-enable-enhanced-instruction-set.py based on the version of vs
> being
> > > used. Is there a convenient way to do that?
> > 
> > I think
> > 
> > int(os.environ.get('GYP_MSVS_VERSION', 0)) >= 2012
> > 
> > would work.
> 
> I think that will only work if GYP_MSVS_VERSION is set by the tester rather
than
> if the version is auto-detected. TestGyp.py has a FindVisualStudioInstallation
> func, but it doesn't appear to expose the version number of the discovered
> devenv. Would you like me to add to TestGyp.py so that consumers can query for
> the discovered version of VS?

Oh sorry, I thought gyptest.py set it as well, but apparently not.

Meh, don't bother, it's a bit tautological anyway, and this CL is a still a
strict improvement over what we have now.

[grt (UTC plus 2), 2014-03-11 17:57:29]

Thanks

https://codereview.chromium.org/195283002/diff/1/test/win/gyptest-cl-enable-e...
File test/win/gyptest-cl-enable-enhanced-instruction-set.py (right):

https://codereview.chromium.org/195283002/diff/1/test/win/gyptest-cl-enable-e...
test/win/gyptest-cl-enable-enhanced-instruction-set.py:17: test =
TestGyp.TestGyp(formats=['msvs', 'ninja'])
On 2014/03/11 16:32:58, scottmg wrote:
> don't need formats= here

Done.

[grt (UTC plus 2), 2014-03-11 17:57:33]

The CQ bit was checked by grt@chromium.org

[scottmg, 2014-03-11 18:01:42]

On 2014/03/11 17:57:33, grt wrote:
> The CQ bit was checked by mailto:grt@chromium.org

gyp doesn't have a CQ unfortunately.

[grt (UTC plus 2), 2014-03-11 18:04:34]

The CQ bit was unchecked by grt@chromium.org

[grt (UTC plus 2), 2014-03-11 18:27:23]

Committed patchset #2 manually as r1865 (presubmit successful).

[scottmg, 2014-03-11 18:43:04]

Based on these revelations, I'm guessing these tests aren't working as intended.
:/

test/msvs/config_attrs/gyptest-config_attrs.py:20:if
os.getenv('GYP_MSVS_VERSION'):
test/msvs/config_attrs/gyptest-config_attrs.py:21:  vc_version =
['VC90','VC100'][int(os.getenv('GYP_MSVS_VERSION')) >= 2010]
test/msvs/external_builder/gyptest-all.py:17:if
int(os.environ.get('GYP_MSVS_VERSION', 0)) < 2010:
test/win/gyptest-cl-analysis.py:17:    int(os.environ.get('GYP_MSVS_VERSION',
0)) >= 2012):

Bug: https://code.google.com/p/gyp/issues/detail?id=413