Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/949d15923c337e09be6012e7af4aab64b2bb1fba
Cr-Commit-Position: refs/heads/master@{#424963}

[dcheng, 2016-10-03 19:59:03]

Description was changed from

==========
Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

BUG=none
==========

to

==========
Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[dcheng, 2016-10-03 19:59:03]

Description was changed from

==========
Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[dcheng, 2016-10-03 20:14:15]

dcheng@chromium.org changed reviewers:
+ vollick@chromium.org

[dcheng, 2016-10-03 20:14:21]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:15:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:18:47]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2016-10-11 23:00:33]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 23:01:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-11 23:13:59]

ping =)

[commit-bot: I haz the power, 2016-10-12 00:18:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 00:18:01]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-10-12 22:10:26]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org, jbroman@chromium.org

[dcheng, 2016-10-12 22:10:27]

Finding new reviewers.

+jbroman, can you review the Blink bits?
+danakj, can you review the cc bits?

[jbroman, 2016-10-12 22:18:40]

blink lgtm

https://codereview.chromium.org/2389973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
(right):

https://codereview.chromium.org/2389973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:567: this);
nit: this wrapping is kinda gross. I guess clang-format insists on it? I'd have
hoped for something like:

m_layer = Platform::current()->compositorSupport()
                             ->createExternalTextureLayer(this);

or something (here and elsewhere). Do you know what's up with this?

[dcheng, 2016-10-12 22:27:03]

https://codereview.chromium.org/2389973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
(right):

https://codereview.chromium.org/2389973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:567: this);
On 2016/10/12 22:18:40, jbroman wrote:
> nit: this wrapping is kinda gross. I guess clang-format insists on it? I'd
have
> hoped for something like:
> 
> m_layer = Platform::current()->compositorSupport()
>                              ->createExternalTextureLayer(this);
> 
> or something (here and elsewhere). Do you know what's up with this?

I don't know the specifics, but I'm guessing clang-format penalizes breaking
before an arrow / dot operator (a lot?) more heavily than it does breaking after
= and (, even though the latter requires two line breaks.

[danakj, 2016-10-13 01:38:58]

cc LGTM

[dcheng, 2016-10-13 02:09:56]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-13 02:10:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 05:36:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-13 05:38:36]

Description was changed from

==========
Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Use std::unique_ptr to signal ownership transfer in WebCompositorSupport

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/949d15923c337e09be6012e7af4aab64b2bb1fba
Cr-Commit-Position: refs/heads/master@{#424963}
==========

[commit-bot: I haz the power, 2016-10-13 05:38:38]

Patchset 3 (id:??) landed as
https://crrev.com/949d15923c337e09be6012e7af4aab64b2bb1fba
Cr-Commit-Position: refs/heads/master@{#424963}