Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2389883005: reflow comments in core/xml* (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
jbroman
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, dominicc+watchlist_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/xml* BUG=563793 Committed: https://crrev.com/56d5d7aa7ad96ad3c853cc128a769404f6e0294c Cr-Commit-Position: refs/heads/master@{#422990}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -74 lines) Patch
M third_party/WebKit/Source/core/xml/DOMParser.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DOMParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XMLSerializer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XMLSerializer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathExpression.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathFunctions.cpp View 4 chunks +10 lines, -6 lines 1 comment Download
M third_party/WebKit/Source/core/xml/XPathPath.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathUtil.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLStyleSheetLibxslt.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessor.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/SharedBufferReader.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 6 chunks +13 lines, -8 lines 2 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 15 chunks +44 lines, -28 lines 2 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 2 months ago (2016-10-04 19:53:35 UTC) #3
jbroman
lgtm; two-space nit is up to you (not a big deal, but slightly weird) https://codereview.chromium.org/2389883005/diff/1/third_party/WebKit/Source/core/xml/XPathFunctions.cpp ...
4 years, 2 months ago (2016-10-04 19:56:52 UTC) #5
Nico
thanks! https://codereview.chromium.org/2389883005/diff/1/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp File third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp (right): https://codereview.chromium.org/2389883005/diff/1/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp#newcode392 third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:392: // called. I don't believe XMLDocumentParserQt needs doEnd ...
4 years, 2 months ago (2016-10-04 20:17:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389883005/1
4 years, 2 months ago (2016-10-04 20:17:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 23:15:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:17:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56d5d7aa7ad96ad3c853cc128a769404f6e0294c
Cr-Commit-Position: refs/heads/master@{#422990}

Powered by Google App Engine
This is Rietveld 408576698