reflow comments in core/xml*

third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

 /*
  * Copyright (C) 2000 Peter Kelly (pmk@post.com)
  * Copyright (C) 2005, 2006, 2008, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008 Holger Hans Peter Freyther
- * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
+ * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
+ * (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
@@ skipping 361 matching lines @@
     m_pendingScript->removeClient(this);
     m_pendingScript = nullptr;
     m_parserBlockingPendingScriptLoadStartTime = 0.0;
   }
   clearCurrentNodeStack();
   ScriptableDocumentParser::detach();
 }
 
 void XMLDocumentParser::end() {
   TRACE_EVENT0("blink", "XMLDocumentParser::end");
-  // XMLDocumentParserLibxml2 will do bad things to the document if doEnd() is called.
-  // I don't believe XMLDocumentParserQt needs doEnd called in the fragment case.
+  // XMLDocumentParserLibxml2 will do bad things to the document if doEnd() is
+  // called.  I don't believe XMLDocumentParserQt needs doEnd called in the

[jbroman, 2016/10/04 19:56:51]

super-duper-nit: vim likes to put two spaces between sentences, but we don't
generally do that. Maybe fix?

[Nico, 2016/10/04 20:17:12]

I use vim's gq to join lines manually, and it defaults to two spaces
after periods.

Looks like we deliberately decided that we don't care about this a while
ago: https://codereview.chromium.org/609633004

+  // fragment case.
   DCHECK(!m_parsingFragment);
 
   doEnd();
 
   // doEnd() call above can detach the parser and null out its document.
   // In that case, we just bail out.
   if (isDetached())
     return;
 
   // doEnd() could process a script tag, thus pausing parsing.
@@ skipping 200 matching lines @@
     return false;
 
   // The libxml doesn't give us a lot of context for deciding whether to allow
   // this request. In the worst case, this load could be for an external
   // entity and the resulting document could simply read the retrieved
   // content. If we had more context, we could potentially allow the parser to
   // load a DTD. As things stand, we take the conservative route and allow
   // same-origin requests only.
   if (!XMLDocumentParserScope::currentDocument->getSecurityOrigin()->canRequest(
           url)) {
-    // FIXME: This is copy/pasted. We should probably build console logging into canRequest().
+    // FIXME: This is copy/pasted. We should probably build console logging into
+    // canRequest().
     if (!url.isNull()) {
       String message =
           "Unsafe attempt to load URL " + url.elidedString() +
           " from frame with URL " +
           XMLDocumentParserScope::currentDocument->url().elidedString() +
           ". Domains, protocols and ports must match.\n";
       XMLDocumentParserScope::currentDocument->addConsoleMessage(
           ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel,
                                  message));
     }
@@ skipping 195 matching lines @@
     Element* element = elemStack.last();
     AttributeCollection attributes = element->attributes();
     for (auto& attribute : attributes) {
       if (attribute.localName() == xmlnsAtom)
         m_defaultNamespaceURI = attribute.value();
       else if (attribute.prefix() == xmlnsAtom)
         m_prefixToNamespaceMap.set(attribute.localName(), attribute.value());
     }
   }
 
-  // If the parent element is not in document tree, there may be no xmlns attribute; just default to the parent's namespace.
+  // If the parent element is not in document tree, there may be no xmlns
+  // attribute; just default to the parent's namespace.
   if (m_defaultNamespaceURI.isNull() && !parentElement->isConnected())
     m_defaultNamespaceURI = parentElement->namespaceURI();
 }
 
 XMLParserContext::~XMLParserContext() {
   if (m_context->myDoc)
     xmlFreeDoc(m_context->myDoc);
   xmlFreeParserCtxt(m_context);
 }
 
@@ skipping 540 matching lines @@
                                        char* target,
                                        size_t targetSize) {
   const char* originalTarget = target;
   WTF::Unicode::ConversionResult conversionResult =
       WTF::Unicode::convertUTF16ToUTF8(&utf16Entity,
                                        utf16Entity + numberOfCodeUnits, &target,
                                        target + targetSize);
   if (conversionResult != WTF::Unicode::conversionOK)
     return 0;
 
-  // Even though we must pass the length, libxml expects the entity string to be null terminated.
+  // Even though we must pass the length, libxml expects the entity string to be
+  // null terminated.
   DCHECK_GT(target, originalTarget + 1);
   *target = '\0';
   return target - originalTarget;
 }
 
 static xmlEntityPtr getXHTMLEntity(const xmlChar* name) {
   UChar utf16DecodedEntity[4];
   size_t numberOfCodeUnits = decodeNamedEntityToUCharArray(
       reinterpret_cast<const char*>(name), utf16DecodedEntity);
   if (!numberOfCodeUnits)
@@ skipping 79 matching lines @@
   // http://bugzilla.gnome.org/show_bug.cgi?id=172255
   // http://bugs.webkit.org/show_bug.cgi?id=5792
 }
 
 void XMLDocumentParser::initializeParserContext(const CString& chunk) {
   xmlSAXHandler sax;
   memset(&sax, 0, sizeof(sax));
 
   // According to http://xmlsoft.org/html/libxml-tree.html#xmlSAXHandler and
   // http://xmlsoft.org/html/libxml-parser.html#fatalErrorSAXFunc the SAX
-  // fatalError callback is unused; error gets all the errors. Use normalErrorHandler
-  // for both the error and fatalError callbacks.
+  // fatalError callback is unused; error gets all the errors. Use
+  // normalErrorHandler for both the error and fatalError callbacks.
   sax.error = normalErrorHandler;
   sax.fatalError = normalErrorHandler;
   sax.characters = charactersHandler;
   sax.processingInstruction = processingInstructionHandler;
   sax.cdataBlock = cdataBlockHandler;
   sax.comment = commentHandler;
   sax.warning = warningHandler;
   sax.startElementNs = startElementNsHandler;
   sax.endElementNs = endElementNsHandler;
   sax.getEntity = getEntityHandler;
@@ skipping 201 matching lines @@
   RefPtr<XMLParserContext> parser =
       XMLParserContext::createStringParser(&sax, &state);
   String parseString = "<?xml version=\"1.0\"?><attrs " + string + " />";
   parseChunk(parser->context(), parseString);
   finishParsing(parser->context());
   attrsOK = state.gotAttributes;
   return state.attributes;
 }
 
 }  // namespace blink