Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2389843002: Reflow comments in Source/modules/{geolocation,imagecapture,mediacapturefromelem… (Closed)

Created:
4 years, 2 months ago by mcasas
Modified:
4 years, 2 months ago
Reviewers:
tkent, scheib
CC:
blink-reviews, chromium-reviews, emircan+watch+mediarecorder_chromium.org, haraken, mcasas+watch+mediarecorder_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in Source/modules/{geolocation,imagecapture,mediacapturefromelem… Context: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc This CL covers: - third_party/WebKit/Source/modules/geolocation/ - third_party/WebKit/Source/modules/imagecapture/ - third_party/WebKit/Source/modules/mediacapturefromelement/ - third_party/WebKit/Source/modules/mediarecorder/ BUG=563793 Committed: https://crrev.com/94615e6fbd1d730ed5446979b57c417b0d241179 Cr-Commit-Position: refs/heads/master@{#422637}

Patch Set 1 : automatic #

Patch Set 2 : some hand reflows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 1 5 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mcasas
tkent@ please double check
4 years, 2 months ago (2016-10-03 16:40:39 UTC) #3
mcasas
scheib@ RS
4 years, 2 months ago (2016-10-03 19:39:55 UTC) #6
scheib
LGTM
4 years, 2 months ago (2016-10-03 19:43:33 UTC) #7
tkent
lgtm
4 years, 2 months ago (2016-10-03 22:53:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389843002/20001
4 years, 2 months ago (2016-10-03 23:05:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 00:45:17 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:47:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94615e6fbd1d730ed5446979b57c417b0d241179
Cr-Commit-Position: refs/heads/master@{#422637}

Powered by Google App Engine
This is Rietveld 408576698