Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

Issue 2389843002: Reflow comments in Source/modules/{geolocation,imagecapture,mediacapturefromelem… (Closed)
Patch Set: some hand reflows Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
index fefa6fbf3aa66de54612a57e82e09810610dc8c7..b007ce4b0b1cf7fda1904f461941c700ae8cea36 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
@@ -61,7 +61,8 @@ void AllocateVideoAndAudioBitrates(ExceptionState& exceptionState,
const bool useAudio = !stream->getAudioTracks().isEmpty();
// Clamp incoming values into a signed integer's range.
- // TODO(mcasas): This section would no be needed if the bit rates are signed or double, see https://github.com/w3c/mediacapture-record/issues/48.
+ // TODO(mcasas): This section would no be needed if the bit rates are signed
+ // or double, see https://github.com/w3c/mediacapture-record/issues/48.
const unsigned kMaxIntAsUnsigned = std::numeric_limits<int>::max();
int overallBps = 0;
@@ -110,7 +111,8 @@ void AllocateVideoAndAudioBitrates(ExceptionState& exceptionState,
// Allocate the remaining |overallBps|, if any, to video.
if (options.hasBitsPerSecond())
videoBps = overallBps - audioBps;
- // Clamp the video bit rate. Avoid clamping if the user has not set it explicitly.
+ // Clamp the video bit rate. Avoid clamping if the user has not set it
+ // explicitly.
if (options.hasVideoBitsPerSecond() || options.hasBitsPerSecond()) {
if (videoBps < kSmallestPossibleVpxBitRate) {
context->addConsoleMessage(ConsoleMessage::create(
@@ -333,7 +335,8 @@ void MediaRecorder::writeData(const char* data,
onError("Amount of tracks in MediaStream has changed.");
}
- // TODO(mcasas): Act as |m_ignoredMutedMedia| instructs if |m_stream| track(s) is in muted() state.
+ // TODO(mcasas): Act as |m_ignoredMutedMedia| instructs if |m_stream| track(s)
+ // is in muted() state.
if (!m_blobData) {
m_blobData = BlobData::create();
@@ -352,12 +355,14 @@ void MediaRecorder::writeData(const char* data,
}
void MediaRecorder::onError(const WebString& message) {
- // TODO(mcasas): Beef up the Error Event and add the |message|, see https://github.com/w3c/mediacapture-record/issues/31
+ // TODO(mcasas): Beef up the Error Event and add the |message|, see
+ // https://github.com/w3c/mediacapture-record/issues/31
scheduleDispatchEvent(Event::create(EventTypeNames::error));
}
void MediaRecorder::createBlobEvent(Blob* blob) {
- // TODO(mcasas): Consider launching an Event with a TypedArray inside, see https://github.com/w3c/mediacapture-record/issues/17.
+ // TODO(mcasas): Consider launching an Event with a TypedArray inside, see
+ // https://github.com/w3c/mediacapture-record/issues/17.
scheduleDispatchEvent(BlobEvent::create(EventTypeNames::dataavailable, blob));
}
« no previous file with comments | « third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698