Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 2389793003: Remove a flag to show storage manager in options page. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.exportPath('options'); 5 cr.exportPath('options');
6 6
7 /** 7 /**
8 * @typedef {{actionLinkText: (string|undefined), 8 * @typedef {{actionLinkText: (string|undefined),
9 * childUser: (boolean|undefined), 9 * childUser: (boolean|undefined),
10 * hasError: (boolean|undefined), 10 * hasError: (boolean|undefined),
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 $('keyboard-settings-button').onclick = function(evt) { 354 $('keyboard-settings-button').onclick = function(evt) {
355 PageManager.showPageByName('keyboard-overlay'); 355 PageManager.showPageByName('keyboard-overlay');
356 chrome.send('coreOptionsUserMetricsAction', 356 chrome.send('coreOptionsUserMetricsAction',
357 ['Options_ShowKeyboardSettings']); 357 ['Options_ShowKeyboardSettings']);
358 }; 358 };
359 $('pointer-settings-button').onclick = function(evt) { 359 $('pointer-settings-button').onclick = function(evt) {
360 PageManager.showPageByName('pointer-overlay'); 360 PageManager.showPageByName('pointer-overlay');
361 chrome.send('coreOptionsUserMetricsAction', 361 chrome.send('coreOptionsUserMetricsAction',
362 ['Options_ShowTouchpadSettings']); 362 ['Options_ShowTouchpadSettings']);
363 }; 363 };
364 if (loadTimeData.getBoolean('enableStorageManager')) { 364 $('storage-manager-button').onclick = function(evt) {
365 $('storage-manager-button').hidden = false; 365 PageManager.showPageByName('storage');
366 $('storage-manager-button').onclick = function(evt) { 366 chrome.send('coreOptionsUserMetricsAction',
367 PageManager.showPageByName('storage'); 367 ['Options_ShowStorageManager']);
368 chrome.send('coreOptionsUserMetricsAction', 368 };
369 ['Options_ShowStorageManager']);
370 };
371 }
372 } 369 }
373 370
374 // Search section. 371 // Search section.
375 $('manage-default-search-engines').onclick = function(event) { 372 $('manage-default-search-engines').onclick = function(event) {
376 PageManager.showPageByName('searchEngines'); 373 PageManager.showPageByName('searchEngines');
377 chrome.send('coreOptionsUserMetricsAction', 374 chrome.send('coreOptionsUserMetricsAction',
378 ['Options_ManageSearchEngines']); 375 ['Options_ManageSearchEngines']);
379 }; 376 };
380 $('default-search-engine').addEventListener('change', 377 $('default-search-engine').addEventListener('change',
381 this.setDefaultSearchEngine_); 378 this.setDefaultSearchEngine_);
(...skipping 2037 matching lines...) Expand 10 before | Expand all | Expand 10 after
2419 2416
2420 settings.hidden = !isVisible; 2417 settings.hidden = !isVisible;
2421 }; 2418 };
2422 } 2419 }
2423 2420
2424 // Export 2421 // Export
2425 return { 2422 return {
2426 BrowserOptions: BrowserOptions 2423 BrowserOptions: BrowserOptions
2427 }; 2424 };
2428 }); 2425 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698