Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2389793003: Remove a flag to show storage manager in options page. (Closed)

Created:
4 years, 2 months ago by fukino
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a flag to show storage manager in options page. The flag --enable-storage-manager was used to show/hide storage manager in options page. The storage manager in options has already been shipped, so we don't need the flag anymore. Note that the storage manager in MD settings is going to be enabled by a different flag: --enable-md-storage-manager. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/242e368f4bb2ee4cecbf8e05b3ca5d0c487022d1 Cr-Commit-Position: refs/heads/master@{#424976}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
fukino
Could you take a look at this CL, too?
4 years, 2 months ago (2016-10-04 10:56:36 UTC) #5
michaelpg
lgtm
4 years, 2 months ago (2016-10-04 21:50:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389793003/1
4 years, 2 months ago (2016-10-05 00:31:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/273759)
4 years, 2 months ago (2016-10-05 00:44:20 UTC) #10
fukino
Oops, I misread the OWNERS file... dbeam@, could you take a look?
4 years, 2 months ago (2016-10-05 01:00:26 UTC) #12
fukino
Ping > dbeam@
4 years, 2 months ago (2016-10-11 07:34:50 UTC) #13
Dan Beam
lgtm
4 years, 2 months ago (2016-10-13 00:29:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389793003/1
4 years, 2 months ago (2016-10-13 06:17:16 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/85840) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-13 06:19:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389793003/20001
4 years, 2 months ago (2016-10-13 06:26:03 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 07:36:08 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 07:38:37 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/242e368f4bb2ee4cecbf8e05b3ca5d0c487022d1
Cr-Commit-Position: refs/heads/master@{#424976}

Powered by Google App Engine
This is Rietveld 408576698