Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: src/isolate.cc

Issue 238973003: Handlify Object::GetPrototype and (most) callers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 03e52679d8bfb1edffe6d7a4605456dbc04ae44a..da636578f0b7ea16393b8b74acecfe71dced0dc5 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1033,10 +1033,10 @@ bool Isolate::IsErrorObject(Handle<Object> obj) {
js_builtins_object(), error_key).ToHandleChecked();
DisallowHeapAllocation no_gc;
- for (Object* prototype = *obj; !prototype->IsNull();
- prototype = prototype->GetPrototype(this)) {
+ for (Handle<Object> prototype = obj; !prototype->IsNull();
+ prototype = Object::GetPrototype(this, prototype)) {
Yang 2014/04/15 13:10:48 The DisallowHeapAllocation scope should already ma
if (!prototype->IsJSObject()) return false;
- if (JSObject::cast(prototype)->map()->constructor() ==
+ if (JSObject::cast(*prototype)->map()->constructor() ==
*error_constructor) {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698