Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/ic-inl.h

Issue 238973003: Handlify Object::GetPrototype and (most) callers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ic.cc ('K') | « src/ic.cc ('k') | src/isolate.cc » ('j') | src/isolate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic-inl.h
diff --git a/src/ic-inl.h b/src/ic-inl.h
index ebe0fb9b35e3e0fd1181757b4053e6e0f6ece72d..4b94aa237abee78db1b2bb86bc9a3b799c781e79 100644
--- a/src/ic-inl.h
+++ b/src/ic-inl.h
@@ -157,13 +157,13 @@ InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object) {
}
-HeapObject* IC::GetCodeCacheHolder(Isolate* isolate,
- Object* object,
- InlineCacheHolderFlag holder) {
+Handle<HeapObject> IC::GetCodeCacheHolder(Isolate* isolate,
+ Handle<Object> object,
+ InlineCacheHolderFlag holder) {
Yang 2014/04/15 13:10:48 No need to handlify.
if (object->IsSmi()) holder = PROTOTYPE_MAP;
- Object* map_owner = holder == OWN_MAP
- ? object : object->GetPrototype(isolate);
- return HeapObject::cast(map_owner);
+ Handle<Object> map_owner = holder == OWN_MAP
+ ? object : Object::GetPrototype(isolate, object);
+ return handle(HeapObject::cast(*map_owner));
}
« src/ic.cc ('K') | « src/ic.cc ('k') | src/isolate.cc » ('j') | src/isolate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698