Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/ic.cc

Issue 238973003: Handlify Object::GetPrototype and (most) callers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index ecf0e9a8d68eca7fb8e611118f2aefc7f58eeeed..8e5ae5b81e307398c24c862ed8dc2ee5d504e98c 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -262,12 +262,12 @@ bool IC::TryRemoveInvalidPrototypeDependentStub(Handle<Object> receiver,
break;
case PROTOTYPE_MAP:
// IC::GetCodeCacheHolder is not applicable.
- if (receiver->GetPrototype(isolate())->IsNull()) return false;
+ if (Object::GetPrototype(isolate(), receiver)->IsNull()) return false;
Yang 2014/04/15 13:10:48 No need to handlify this.
break;
}
Handle<Map> map(
- IC::GetCodeCacheHolder(isolate(), *receiver, cache_holder)->map());
+ IC::GetCodeCacheHolder(isolate(), receiver, cache_holder)->map());
// Decide whether the inline cache failed because of changes to the
// receiver itself or changes to one of its prototypes.
@@ -904,7 +904,7 @@ Handle<Code> IC::ComputeHandler(LookupResult* lookup,
Handle<Object> value) {
InlineCacheHolderFlag cache_holder = GetCodeCacheForObject(*object);
Handle<HeapObject> stub_holder(GetCodeCacheHolder(
- isolate(), *object, cache_holder));
+ isolate(), object, cache_holder));
Handle<Code> code = isolate()->stub_cache()->FindHandler(
name, handle(stub_holder->map()), kind(), cache_holder,
@@ -978,7 +978,7 @@ Handle<Code> LoadIC::CompileHandler(LookupResult* lookup,
type, global, cell, name, lookup->IsDontDelete());
// TODO(verwaest): Move caching of these NORMAL stubs outside as well.
Handle<HeapObject> stub_holder(GetCodeCacheHolder(
- isolate(), *object, cache_holder));
+ isolate(), object, cache_holder));
HeapObject::UpdateMapCodeCache(stub_holder, name, code);
return code;
}

Powered by Google App Engine
This is Rietveld 408576698