Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: third_party/WebKit/Source/core/page/FocusController.cpp

Issue 2389673002: Prune createVisibleSelectionDeprecated from FocusController (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/FocusController.cpp
diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp
index 5d9392435ee3adf64d68843f07f22809cc363512..073a75ae89bc6c0a06146fd4062e8c887e9a92f2 100644
--- a/third_party/WebKit/Source/core/page/FocusController.cpp
+++ b/third_party/WebKit/Source/core/page/FocusController.cpp
@@ -1069,6 +1069,13 @@ bool FocusController::advanceFocusInDocumentOrder(
setFocusedFrame(newDocument.frame());
if (caretBrowsing) {
+ // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+ // needs to be audited. See http://crbug.com/590369 for more details.
+ // In the long term, we should change FrameSelection::setSelection to take a
+ // parameter that does not require clean layout, so that modifying selection
+ // no longer performs synchronous layout by itself.
+ newDocument.updateStyleAndLayoutIgnorePendingStylesheets();
+
Position position = firstPositionInOrBeforeNode(element);
VisibleSelection newSelection =
createVisibleSelectionDeprecated(position, position);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698