Prune createVisibleSelectionDeprecated from FocusController

third_party/WebKit/Source/core/page/FocusController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nuanti Ltd.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1051 matching lines @@
 
   if (&newDocument != document) {
     // Focus is going away from this document, so clear the focused element.
     document->clearFocusedElement();
     document->setSequentialFocusNavigationStartingPoint(nullptr);
   }
 
   setFocusedFrame(newDocument.frame());
 
   if (caretBrowsing) {
+    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+    // needs to be audited.  See http://crbug.com/590369 for more details.
+    // In the long term, we should change FrameSelection::setSelection to take a
+    // parameter that does not require clean layout, so that modifying selection
+    // no longer performs synchronous layout by itself.
+    newDocument.updateStyleAndLayoutIgnorePendingStylesheets();
+
     Position position = firstPositionInOrBeforeNode(element);
     VisibleSelection newSelection =
         createVisibleSelectionDeprecated(position, position);
     frame->selection().setSelection(newSelection);
   }
 
   element->focus(
       FocusParams(SelectionBehaviorOnFocus::Reset, type, sourceCapabilities));
   return true;
 }
@@ skipping 355 matching lines @@
 
   return consumed;
 }
 
 DEFINE_TRACE(FocusController) {
   visitor->trace(m_page);
   visitor->trace(m_focusedFrame);
 }
 
 }  // namespace blink