Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2389643002: Reflow comments in core/fetch (Closed)

Created:
4 years, 2 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
Reviewers:
Yoav Weiss, Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in core/fetch BUG=563793 Committed: https://crrev.com/22a064d580892d6032977eff027a25abe132cfa8 Cr-Commit-Position: refs/heads/master@{#422416}

Patch Set 1 #

Patch Set 2 : update some comments near copyright #

Total comments: 14

Patch Set 3 : yoavs comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -433 lines) Patch
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 1 8 chunks +19 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp View 11 chunks +32 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp View 9 chunks +17 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/DocumentResource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchRequest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 3 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 7 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceObserver.h View 1 chunk +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 7 chunks +17 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 1 2 6 chunks +46 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 16 chunks +48 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp View 6 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 3 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 2 7 chunks +19 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 2 13 chunks +44 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceClient.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceClientWalker.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 2 4 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 2 29 chunks +127 lines, -107 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoaderOptions.h View 4 chunks +21 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoaderOptionsTest.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/StyleSheetResourceClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Charlie Harrison
japhet, ptal? Thanks!
4 years, 2 months ago (2016-10-03 02:13:56 UTC) #4
Yoav Weiss
LGTM % indentation nits https://codereview.chromium.org/2389643002/diff/20001/third_party/WebKit/Source/core/fetch/MemoryCache.h File third_party/WebKit/Source/core/fetch/MemoryCache.h (right): https://codereview.chromium.org/2389643002/diff/20001/third_party/WebKit/Source/core/fetch/MemoryCache.h#newcode188 third_party/WebKit/Source/core/fetch/MemoryCache.h:188: // consume when the cache ...
4 years, 2 months ago (2016-10-03 08:52:20 UTC) #6
Charlie Harrison
Thanks for the review! https://codereview.chromium.org/2389643002/diff/20001/third_party/WebKit/Source/core/fetch/MemoryCache.h File third_party/WebKit/Source/core/fetch/MemoryCache.h (right): https://codereview.chromium.org/2389643002/diff/20001/third_party/WebKit/Source/core/fetch/MemoryCache.h#newcode188 third_party/WebKit/Source/core/fetch/MemoryCache.h:188: // consume when the cache ...
4 years, 2 months ago (2016-10-03 12:36:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389643002/40001
4 years, 2 months ago (2016-10-03 12:37:15 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 14:29:39 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 14:32:41 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/22a064d580892d6032977eff027a25abe132cfa8
Cr-Commit-Position: refs/heads/master@{#422416}

Powered by Google App Engine
This is Rietveld 408576698