Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Side by Side Diff: third_party/WebKit/Source/core/fetch/ScriptResource.cpp

Issue 2389643002: Reflow comments in core/fetch (Closed)
Patch Set: yoavs comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
11 version 2 of the License, or (at your option) any later version. 11 version 2 of the License, or (at your option) any later version.
12 12
13 This library is distributed in the hope that it will be useful, 13 This library is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of 14 but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 Library General Public License for more details. 16 Library General Public License for more details.
17 17
18 You should have received a copy of the GNU Library General Public License 18 You should have received a copy of the GNU Library General Public License
19 along with this library; see the file COPYING.LIB. If not, write to 19 along with this library; see the file COPYING.LIB. If not, write to
20 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 20 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
21 Boston, MA 02110-1301, USA. 21 Boston, MA 02110-1301, USA.
22 22
23 This class provides all functionality needed for loading images, style sheet s and html 23 This class provides all functionality needed for loading images, style
24 pages from the web. It has a memory cache for these objects. 24 sheets and html pages from the web. It has a memory cache for these objects.
25 */ 25 */
26 26
27 #include "core/fetch/ScriptResource.h" 27 #include "core/fetch/ScriptResource.h"
28 28
29 #include "core/fetch/FetchRequest.h" 29 #include "core/fetch/FetchRequest.h"
30 #include "core/fetch/IntegrityMetadata.h" 30 #include "core/fetch/IntegrityMetadata.h"
31 #include "core/fetch/ResourceClientWalker.h" 31 #include "core/fetch/ResourceClientWalker.h"
32 #include "core/fetch/ResourceFetcher.h" 32 #include "core/fetch/ResourceFetcher.h"
33 #include "platform/MIMETypeRegistry.h" 33 #include "platform/MIMETypeRegistry.h"
34 #include "platform/SharedBuffer.h" 34 #include "platform/SharedBuffer.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 memoryDump->addSuballocation( 83 memoryDump->addSuballocation(
84 dump->guid(), String(WTF::Partitions::kAllocatedObjectPoolName)); 84 dump->guid(), String(WTF::Partitions::kAllocatedObjectPoolName));
85 } 85 }
86 86
87 const String& ScriptResource::script() { 87 const String& ScriptResource::script() {
88 DCHECK(isLoaded()); 88 DCHECK(isLoaded());
89 89
90 if (m_script.isNull() && data()) { 90 if (m_script.isNull() && data()) {
91 String script = decodedText(); 91 String script = decodedText();
92 clearData(); 92 clearData();
93 // We lie a it here and claim that script counts as encoded data (even thoug h it's really decoded data). 93 // We lie a bit here and claim that script counts as encoded data (even
94 // That's because the MemoryCache thinks that it can clear out decoded data by calling destroyDecodedData(), 94 // though it's really decoded data). That's because the MemoryCache thinks
95 // but we can't destroy script in destroyDecodedData because that's our only copy of the data! 95 // that it can clear out decoded data by calling destroyDecodedData(), but
96 // we can't destroy script in destroyDecodedData because that's our only
97 // copy of the data!
96 setEncodedSize(script.charactersSizeInBytes()); 98 setEncodedSize(script.charactersSizeInBytes());
97 m_script = AtomicString(script); 99 m_script = AtomicString(script);
98 } 100 }
99 101
100 return m_script; 102 return m_script;
101 } 103 }
102 104
103 void ScriptResource::destroyDecodedDataForFailedRevalidation() { 105 void ScriptResource::destroyDecodedDataForFailedRevalidation() {
104 m_script = AtomicString(); 106 m_script = AtomicString();
105 } 107 }
(...skipping 12 matching lines...) Expand all
118 bool ScriptResource::mustRefetchDueToIntegrityMetadata( 120 bool ScriptResource::mustRefetchDueToIntegrityMetadata(
119 const FetchRequest& request) const { 121 const FetchRequest& request) const {
120 if (request.integrityMetadata().isEmpty()) 122 if (request.integrityMetadata().isEmpty())
121 return false; 123 return false;
122 124
123 return !IntegrityMetadata::setsEqual(m_integrityMetadata, 125 return !IntegrityMetadata::setsEqual(m_integrityMetadata,
124 request.integrityMetadata()); 126 request.integrityMetadata());
125 } 127 }
126 128
127 } // namespace blink 129 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ScriptResource.h ('k') | third_party/WebKit/Source/core/fetch/StyleSheetResourceClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698