Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2389633002: reflow comments in web/ (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, caseq+blink_chromium.org, aboxhall, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, dcheng, devtools-reviews_chromium.org, blink-reviews, je_julie, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in web/ BUG=563793 Committed: https://crrev.com/a66ca9569860c72763c89146704a4a8c68efaffc Cr-Commit-Position: refs/heads/master@{#422356}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -392 lines) Patch
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 4 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp View 5 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/CompositorMutatorImpl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorMutatorImpl.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorProxyClientImpl.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/FindInPageCoordinates.h View 1 chunk +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/FindInPageCoordinates.cpp View 4 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 2 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 9 chunks +29 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImplTest.cpp View 2 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/OpenedFrameTracker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/RotationViewportAnchor.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp View 5 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.h View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 6 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMMessageEvent.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDataSourceImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameContentDumper.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameImplBase.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializer.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 10 chunks +25 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 6 chunks +21 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLeakDetector.cpp View 3 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 3 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 16 chunks +51 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPepperSocketImpl.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 2 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 5 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 3 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebSelection.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebSurroundingText.cpp View 1 chunk +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 35 chunks +99 lines, -70 lines 0 comments Download
M third_party/WebKit/Source/web/mac/WebSubstringUtil.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Nico
The first one done with some semi-automation (see "if you use vim" i added to ...
4 years, 2 months ago (2016-10-02 22:35:26 UTC) #5
dcheng
lgtm
4 years, 2 months ago (2016-10-03 00:35:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389633002/20001
4 years, 2 months ago (2016-10-03 00:37:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 00:43:12 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 00:46:01 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a66ca9569860c72763c89146704a4a8c68efaffc
Cr-Commit-Position: refs/heads/master@{#422356}

Powered by Google App Engine
This is Rietveld 408576698