third_party/WebKit/Source/web/OpenedFrameTracker.cpp - Issue 2389633002: reflow comments in web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/OpenedFrameTracker.cpp

Issue 2389633002: reflow comments in web/ (Closed)

Patch Set: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/OpenedFrameTracker.cpp

diff --git a/third_party/WebKit/Source/web/OpenedFrameTracker.cpp b/third_party/WebKit/Source/web/OpenedFrameTracker.cpp

index 9463d86efedb00c65d6942ad50bfe4c2468eb436..4efde8b6d9a5105529f3383ad581ea0510ca96c4 100644

--- a/third_party/WebKit/Source/web/OpenedFrameTracker.cpp

+++ b/third_party/WebKit/Source/web/OpenedFrameTracker.cpp

@@ -26,7 +26,8 @@ void OpenedFrameTracker::remove(WebFrame* frame) {

}

void OpenedFrameTracker::transferTo(WebFrame* opener) {

- // Copy the set of opened frames, since changing the owner will mutate this set.

+ // Copy the set of opened frames, since changing the owner will mutate this

+ // set.

HashSet<WebFrame*> frames(m_openedFrames);

for (WebFrame* frame : frames)

frame->setOpener(opener);