Issue 238963002: Use EventRouter instead of ExtensionSystem::Get->event_router()

Issue 238963002: Use EventRouter instead of ExtensionSystem::Get->event_router() (Closed)

Created:
6 years, 8 months ago by limasdf

Modified:
6 years, 8 months ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use EventRouter instead of ExtensionSystem::Get->event_router() BUG=362672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264180

Patch Set 1 : #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -41 lines)			Patch
M	chrome/browser/chromeos/extensions/input_method_api.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/input_method_event_router.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/media_player_event_router.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/screenlock_private_api.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/event_router_forwarder.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/permissions_updater.cc	View	3 chunks	+3 lines, -5 lines	2 comments	Download
M	chrome/browser/ui/app_list/search/people/people_result.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	extensions/browser/api/storage/storage_frontend.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	extensions/browser/extension_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/extension_message_filter.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

benwells

lgtm https://codereview.chromium.org/238963002/diff/20001/chrome/browser/extensions/permissions_updater.cc File chrome/browser/extensions/permissions_updater.cc (right): https://codereview.chromium.org/238963002/diff/20001/chrome/browser/extensions/permissions_updater.cc#newcode104 chrome/browser/extensions/permissions_updater.cc:104: ->DispatchEventToExtension(extension_id, event.Pass()); Is this clang format?

6 years, 8 months ago (2014-04-16 04:43:03 UTC) #2

limasdf

Thanks for the review! https://codereview.chromium.org/238963002/diff/20001/chrome/browser/extensions/permissions_updater.cc File chrome/browser/extensions/permissions_updater.cc (right): https://codereview.chromium.org/238963002/diff/20001/chrome/browser/extensions/permissions_updater.cc#newcode104 chrome/browser/extensions/permissions_updater.cc:104: ->DispatchEventToExtension(extension_id, event.Pass()); It is automatically ...

6 years, 8 months ago (2014-04-16 04:50:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/238963002/20001

6 years, 8 months ago (2014-04-16 04:51:42 UTC) #5

Message was sent while issue was closed.

Change committed as 264180

Expand Messages | Collapse Messages