chrome/browser/extensions/permissions_updater.cc - Issue 238963002: Use EventRouter instead of ExtensionSystem::Get->event_router()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/permissions_updater.cc

Issue 238963002: Use EventRouter instead of ExtensionSystem::Get->event_router() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/event_router_forwarder.cc ('k') | chrome/browser/ui/app_list/search/people/people_result.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/permissions_updater.cc

diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc

index 9dc8f82035f6a2374ecf31bfde58106fc9b91130..b98bd0cfc09286d544f3af80024d44e6ecccf184 100644

--- a/chrome/browser/extensions/permissions_updater.cc

+++ b/chrome/browser/extensions/permissions_updater.cc

@@ -17,7 +17,6 @@

#include "content/public/browser/render_process_host.h"

#include "extensions/browser/event_router.h"

#include "extensions/browser/extension_prefs.h"

-#include "extensions/browser/extension_system.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_messages.h"

#include "extensions/common/permissions/permissions_data.h"

@@ -92,8 +91,7 @@ void PermissionsUpdater::DispatchEvent(

const std::string& extension_id,

const char* event_name,

const PermissionSet* changed_permissions) {

- if (!profile_ ||

- !ExtensionSystem::Get(profile_)->event_router())

+ if (!profile_ || !EventRouter::Get(profile_))

return;

scoped_ptr<base::ListValue> value(new base::ListValue());

@@ -102,8 +100,8 @@ void PermissionsUpdater::DispatchEvent(

value->Append(permissions->ToValue().release());

scoped_ptr<Event> event(new Event(event_name, value.Pass()));

event->restrict_to_browser_context = profile_;

- ExtensionSystem::Get(profile_)->event_router()->

- DispatchEventToExtension(extension_id, event.Pass());

+ EventRouter::Get(profile_)

+ ->DispatchEventToExtension(extension_id, event.Pass());

benwells 2014/04/16 04:43:03 Is this clang format?

limasdf 2014/04/16 04:50:20 It is automatically fixed by 'git cl format' when

}

void PermissionsUpdater::NotifyPermissionsUpdated(

« no previous file with comments | « chrome/browser/extensions/event_router_forwarder.cc ('k') | chrome/browser/ui/app_list/search/people/people_result.cc » ('j') | no next file with comments »