Issue 238933009: Remove --disable-accelerated-compositing

Issue 238933009: Remove --disable-accelerated-compositing (Closed)

Created:
6 years, 8 months ago by piman

Modified:
6 years, 8 months ago

Reviewers:
danakj, Ken Russell (switch to Gerrit), Scott Hess - ex-Googler, mattm

CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, jbauman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove --disable-accelerated-compositing After r264075, this is not used by the renderer. Also, nothing sets it but tests (and for the wrong reasons). Also, it's not like it works any more after r264103. Replace it in tests by --disable-gpu, and remove from the code. BUG=362164 R=danakj@chromium.org, kbr@chromium.org, shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264295

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -118 lines)			Patch
M	chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/gpu/gpu_feature_browsertest.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	content/browser/gpu/compositor_util.cc	View	6 chunks	+4 lines, -12 lines	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl_private.cc	View	4 chunks	+2 lines, -11 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_browsertest.cc	View	3 chunks	+0 lines, -58 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/dom_serializer_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/resource_fetcher_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/savable_resources_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

piman

danakj: please review kbr: OWNERS for chrome/test/gpu/gpu_feature_browsertest.cc (removing a test case that is not used ...

6 years, 8 months ago (2014-04-16 04:37:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/238933009/1

6 years, 8 months ago (2014-04-16 20:25:20 UTC) #7

piman

6 years, 8 months ago (2014-04-16 20:26:01 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 manually as r264295 (presubmit successful).

Expand Messages | Collapse Messages