Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 238933009: Remove --disable-accelerated-compositing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_browsertest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_browsertest.cc
index 7101e9dd38bf1edafb784f114b13185341ec04de..7602b11a6e0bf7ba4446cd286e171d4c1cf3c2c1 100644
--- a/content/browser/renderer_host/render_widget_host_view_browsertest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_browsertest.cc
@@ -277,49 +277,6 @@ class CompositingRenderWidgetHostViewBrowserTest
DISALLOW_COPY_AND_ASSIGN(CompositingRenderWidgetHostViewBrowserTest);
};
-class NonCompositingRenderWidgetHostViewBrowserTest
- : public RenderWidgetHostViewBrowserTest {
- public:
- NonCompositingRenderWidgetHostViewBrowserTest() {}
-
- virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
- // Note: Appending the kDisableAcceleratedCompositing switch here, but there
- // are some builds that only use compositing and will ignore this switch.
- // Therefore, the call to SetUpSourceSurface() later on will detect whether
- // compositing mode is actually off. If it's on, the tests will pass
- // blindly, logging a warning message, since we cannot test what the
- // platform/implementation does not support.
- command_line->AppendSwitch(switches::kDisableAcceleratedCompositing);
- RenderWidgetHostViewBrowserTest::SetUpCommandLine(command_line);
- }
-
- virtual GURL TestUrl() {
- return GURL(kAboutBlankURL);
- }
-
- virtual bool SetUpSourceSurface(const char* wait_message) OVERRIDE {
- if (IsForceCompositingModeEnabled())
- return false; // See comment in SetUpCommandLine().
-
- content::DOMMessageQueue message_queue;
- NavigateToURL(shell(), TestUrl());
- if (wait_message != NULL) {
- std::string result(wait_message);
- if (!message_queue.WaitForMessage(&result)) {
- EXPECT_TRUE(false) << "WaitForMessage " << result << " failed.";
- return false;
- }
- }
-
- WaitForCopySourceReady();
- // Return whether the renderer left accelerated compositing turned off.
- return !GetRenderWidgetHost()->is_accelerated_compositing_active();
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(NonCompositingRenderWidgetHostViewBrowserTest);
-};
-
class FakeFrameSubscriber : public RenderWidgetHostViewFrameSubscriber {
public:
FakeFrameSubscriber(
@@ -358,13 +315,6 @@ IN_PROC_BROWSER_TEST_P(CompositingRenderWidgetHostViewBrowserTest,
RunBasicCopyFromBackingStoreTest();
}
-// The CopyFromBackingStore() API should work on all platforms when compositing
-// is disabled.
-IN_PROC_BROWSER_TEST_F(NonCompositingRenderWidgetHostViewBrowserTest,
- CopyFromBackingStore) {
- RunBasicCopyFromBackingStoreTest();
-}
-
// Tests that the callback passed to CopyFromBackingStore is always called,
// even when the RenderWidgetHost is deleting in the middle of an async copy.
IN_PROC_BROWSER_TEST_P(CompositingRenderWidgetHostViewBrowserTest,
@@ -423,14 +373,6 @@ IN_PROC_BROWSER_TEST_P(CompositingRenderWidgetHostViewBrowserTest,
EXPECT_EQ(1, callback_invoke_count());
}
-// With compositing turned off, no platforms should support the
-// CopyFromCompositingSurfaceToVideoFrame() API.
-IN_PROC_BROWSER_TEST_F(NonCompositingRenderWidgetHostViewBrowserTest,
- CopyFromCompositingSurfaceToVideoFrameCallbackTest) {
- SET_UP_SURFACE_OR_PASS_TEST(NULL);
- EXPECT_FALSE(GetRenderWidgetHostViewPort()->CanCopyToVideoFrame());
-}
-
// Test basic frame subscription functionality. We subscribe, and then run
// until at least one DeliverFrameCallback has been invoked.
IN_PROC_BROWSER_TEST_P(CompositingRenderWidgetHostViewBrowserTest,
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698