Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2389313002: Avoid static initializers in PropertyAccessCompiler (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, caitp
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid static initializers in PropertyAccessCompiler Introduce AccessCompilerData which hangs off the Isolate, and initialize it when the first PropertyAccessCompiler is instantiated. This avoids TSAN failures when trying to access load/store calling convention arrays. BUG=v8:5427 Committed: https://crrev.com/b5c542bac8660ada1b55acd6f10fd0cb1cb8115e Cr-Commit-Position: refs/heads/master@{#40055}

Patch Set 1 #

Patch Set 2 : Remove unused include #

Patch Set 3 : Ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -117 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/access-compiler.h View 1 2 4 chunks +5 lines, -7 lines 0 comments Download
M src/ic/access-compiler.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
A src/ic/access-compiler-data.h View 1 1 chunk +48 lines, -0 lines 0 comments Download
M src/ic/arm/access-compiler-arm.cc View 1 2 1 chunk +10 lines, -12 lines 0 comments Download
M src/ic/arm64/access-compiler-arm64.cc View 1 2 1 chunk +11 lines, -12 lines 0 comments Download
M src/ic/ia32/access-compiler-ia32.cc View 1 2 1 chunk +10 lines, -11 lines 0 comments Download
M src/ic/mips/access-compiler-mips.cc View 1 2 1 chunk +10 lines, -12 lines 0 comments Download
M src/ic/mips64/access-compiler-mips64.cc View 1 2 1 chunk +10 lines, -12 lines 0 comments Download
M src/ic/ppc/access-compiler-ppc.cc View 1 2 1 chunk +10 lines, -12 lines 0 comments Download
M src/ic/s390/access-compiler-s390.cc View 1 2 1 chunk +11 lines, -10 lines 0 comments Download
M src/ic/x64/access-compiler-x64.cc View 1 2 1 chunk +10 lines, -13 lines 0 comments Download
M src/ic/x87/access-compiler-x87.cc View 1 2 1 chunk +10 lines, -11 lines 0 comments Download
M src/isolate.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/isolate.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
adamk
Hi Mike, Here's something based on your comments on the attached bug. Let me know ...
4 years, 2 months ago (2016-10-04 22:07:07 UTC) #2
adamk
+caitp fyi
4 years, 2 months ago (2016-10-04 22:37:51 UTC) #3
mvstanton
lgtm
4 years, 2 months ago (2016-10-05 12:20:41 UTC) #4
adamk
Ports done, PTAL for a sanity check
4 years, 2 months ago (2016-10-05 17:16:19 UTC) #7
mvstanton
Sanity confirmed, still lgtm :)
4 years, 2 months ago (2016-10-06 08:45:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389313002/40001
4 years, 2 months ago (2016-10-06 17:50:32 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 18:19:51 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 18:20:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b5c542bac8660ada1b55acd6f10fd0cb1cb8115e
Cr-Commit-Position: refs/heads/master@{#40055}

Powered by Google App Engine
This is Rietveld 408576698