[regexp] Port RegExp getters and setters

[regexp] Port RegExp getters and setters

Flag getters are implemented as TurboFan stubs while the rest are written as
C++. This distinction is somewhat arbitrary and more getters could be ported to
TurboFan in the future.

BUG=v8:5339
Committed: https://crrev.com/4e219bb46a03800aa89acd46e81a428417c0e9a2
Cr-Commit-Position: refs/heads/master@{#40036}

[jgruber, 2016-10-04 14:48:51]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 14:49:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 14:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 14:50:34]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[jgruber, 2016-10-05 09:16:17]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 09:16:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-05 09:26:12]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-10-05 09:26:12]

The TurboFan getters are quite a contrast to JS regarding readability. C++
implementations, unfortunately, are slow.

Given that these are probably not extremely perf critical, I'd also be fine in
just implementing all of these in C++. WDYT?

[commit-bot: I haz the power, 2016-10-05 09:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 09:34:51]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10143)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[jgruber, 2016-10-05 10:56:36]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 10:56:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 11:18:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 11:18:13]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[jgruber, 2016-10-05 11:42:50]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 11:43:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 12:30:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 12:30:43]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jgruber, 2016-10-05 13:26:06]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 13:26:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 14:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:14:07]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-10-05 14:30:04]

On 2016/10/05 09:26:12, jgruber wrote:
> The TurboFan getters are quite a contrast to JS regarding readability. C++
> implementations, unfortunately, are slow.
> 
> Given that these are probably not extremely perf critical, I'd also be fine in
> just implementing all of these in C++. WDYT?

FYI: win is currently broken on ToT

[Benedikt Meurer, 2016-10-05 16:39:22]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-10-05 16:39:23]

https://codereview.chromium.org/2389233002/diff/20002/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2389233002/diff/20002/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:513: Node* const map = ThrowIfNotJSReceiver(a,
isolate, context, receiver,
This could be more efficient if we first check for the likely case, i.e. the
initial regexp map (modulo the initial smi check) and only do a JSReceiver check
in the unlikely case.

[Yang, 2016-10-06 07:56:13]

lgtm

https://codereview.chromium.org/2389233002/diff/20002/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2389233002/diff/20002/src/bootstrapper.cc#new...
src/bootstrapper.cc:1721: // specification at
Good to know.

[jgruber, 2016-10-06 12:34:34]

https://codereview.chromium.org/2389233002/diff/20002/src/builtins/builtins-r...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2389233002/diff/20002/src/builtins/builtins-r...
src/builtins/builtins-regexp.cc:513: Node* const map = ThrowIfNotJSReceiver(a,
isolate, context, receiver,
On 2016/10/05 16:39:23, Benedikt Meurer wrote:
> This could be more efficient if we first check for the likely case, i.e. the
> initial regexp map (modulo the initial smi check) and only do a JSReceiver
check
> in the unlikely case.

Ack. I'll add this to my backlog and fix all usages of this at once when the
remaining regexp port has landed.

[jgruber, 2016-10-06 12:34:39]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-10-06 12:34:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 13:01:00]

Committed patchset #4 (id:20002)

[commit-bot: I haz the power, 2016-10-06 13:01:16]

Description was changed from

==========
[regexp] Port RegExp getters and setters

Flag getters are implemented as TurboFan stubs while the rest are written as
C++. This distinction is somewhat arbitrary and more getters could be ported to
TurboFan in the future.

BUG=v8:5339
==========

to

==========
[regexp] Port RegExp getters and setters

Flag getters are implemented as TurboFan stubs while the rest are written as
C++. This distinction is somewhat arbitrary and more getters could be ported to
TurboFan in the future.

BUG=v8:5339

Committed: https://crrev.com/4e219bb46a03800aa89acd46e81a428417c0e9a2
Cr-Commit-Position: refs/heads/master@{#40036}
==========

[commit-bot: I haz the power, 2016-10-06 13:01:17]

Patchset 4 (id:??) landed as
https://crrev.com/4e219bb46a03800aa89acd46e81a428417c0e9a2
Cr-Commit-Position: refs/heads/master@{#40036}