Issue 238923010: Remove unused endContext().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238923010: Remove unused endContext(). (Closed)

Created:
6 years, 8 months ago by scroggo

Modified:
6 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Remove unused endContext(). Prior to r14216, this was called by SkBitmapProcShader::endContext. That call has been removed, and it its place, the SkBitmapProcShader destroys the SkBitmapProcState. All the work done by endContext() is done by the destructor, so this function is no longer needed.

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -17 lines)			Patch
	M	src/core/SkBitmapProcState.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	src/core/SkBitmapProcState.cpp	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

6 years, 8 months ago (2014-04-22 18:59:40 UTC) #3

On 2014/04/17 14:25:08, reed1 wrote:
> uncalled code should be deleted
> 
> lgtm

This has been merged into https://codereview.chromium.org/207683004/

Expand Messages | Collapse Messages