Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: test/mac/unicode-settings/test.gyp

Issue 23892016: Fix XCObject._EncodeString() for unicode characters. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Add tests. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mac/unicode-settings/test.gyp
diff --git a/test/mac/postbuild-defaults/test.gyp b/test/mac/unicode-settings/test.gyp
similarity index 50%
copy from test/mac/postbuild-defaults/test.gyp
copy to test/mac/unicode-settings/test.gyp
index be0a075efc6f0c5b6274a426ab390d5aa58c6d87..fc58744789471831ff3cd8dca1157b26090408b6 100644
--- a/test/mac/postbuild-defaults/test.gyp
+++ b/test/mac/unicode-settings/test.gyp
@@ -4,21 +4,17 @@
{
'targets': [
{
- 'target_name': 'test_app',
- 'product_name': 'Test',
+ 'target_name': 'myapp',
'type': 'executable',
'mac_bundle': 1,
- 'sources': [ 'main.c', ],
+ 'sources': [ 'file.cc', ],
'xcode_settings': {
- 'INFOPLIST_FILE': 'Info.plist',
+ 'BUNDLE_DISPLAY_NAME': 'α',
},
Mark Mentovai 2013/09/12 21:32:18 Maybe add a couple more funny characters here, lik
kbongort 2013/09/12 22:41:40 I added a check for the tab character.
'postbuilds': [
{
- 'postbuild_name': 'Postbuild that calls defaults',
- 'action': [
- './postbuild-defaults.sh',
- '${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}',
- ],
+ 'postbuild_name': 'envtest',
+ 'action': [ './test_bundle_display_name.sh', ],
},
],
},

Powered by Google App Engine
This is Rietveld 408576698