pylib/gyp/xcodeproj_file.py - Issue 23892016: Fix XCObject._EncodeString() for unicode characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/xcodeproj_file.py

Issue 23892016: Fix XCObject._EncodeString() for unicode characters. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: Add tests. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/xcodeproj_file.py

diff --git a/pylib/gyp/xcodeproj_file.py b/pylib/gyp/xcodeproj_file.py

index 47712a7f6e092b0ca998e6b42792b1a21c031133..4db6419f6d565c87c66d9f0d06e2d0515bdc3c84 100644

--- a/pylib/gyp/xcodeproj_file.py

+++ b/pylib/gyp/xcodeproj_file.py

@@ -169,7 +169,7 @@ _quoted = re.compile('___')

# This pattern should match any character that needs to be escaped by

# XCObject._EncodeString. See that function.

-_escaped = re.compile('[\\\\"]|[^ -~]')

+_escaped = re.compile('[\\\\"]|[\x00-\x1f\x7f]')

Mark Mentovai 2013/09/12 21:32:18 Why is 0x7f in here? If the input contains a DEL c

kbongort 2013/09/12 22:41:40 This was to keep the former behavior, but the comm

# Used by SourceTreeAndPathFromPath

« no previous file with comments | « no previous file | test/mac/gyptest-unicode-settings.py » ('j') | test/mac/unicode-settings/test.gyp » ('J')