[Sync] Fixing easy lint violations.

components/sync/syncable/directory_backing_store.cc

Index: components/sync/syncable/directory_backing_store.cc
diff --git a/components/sync/syncable/directory_backing_store.cc b/components/sync/syncable/directory_backing_store.cc
index 761cd2cc8f8c1bc28b54a75d798b71daa63f73b7..f7f2ecd5eef55608351d59c036f10fcb3612fe96 100644
--- a/components/sync/syncable/directory_backing_store.cc
+++ b/components/sync/syncable/directory_backing_store.cc
@@ -8,6 +8,7 @@
 
 #include <limits>
 #include <unordered_set>
+#include <utility>
 
 #include "base/base64.h"
 #include "base/location.h"
@@ -235,7 +236,7 @@ bool SaveEntryToDB(sql::Statement* save_statement, const EntryKernel& entry) {
 // copy for some entries which create by copy-on-write mechanism.
 // entries_counts : entry counts for each model type.
 void UploadModelTypeEntryCount(const int total_specifics_copies,
-                               const int(&entries_counts)[MODEL_TYPE_COUNT]) {

[maxbogue, 2016/10/04 00:11:51]

Wat. Was this previously accepting a reference to the array? Wouldn't you be
copying the array now? The parens don't seem necessary though...

[skym, 2016/10/04 15:57:35]

Whoops, okay after Googling to try to better explain to you why this is safe, it
turns out it is not, reverting.

So, I looked up yesterday how to pass an array by reference, and it seemed that
arrays were always passed by reference, so I was like, great, lets remove this
funky syntax.

Googling again though
http://stackoverflow.com/questions/5724171/passing-an-array-by-reference/5724...
, it looks like the size gets ignored with the syntax I moved to. So back to the
original.

However, it seems if I just add a space between "int" and "(&entries_count)" we
dodge the lint complaint. Yay!

[maxbogue, 2016/10/04 16:24:45]

Ah, cool!

+                               const int entries_counts[MODEL_TYPE_COUNT]) {
   int total_entry_counts = 0;
   for (int i = FIRST_REAL_MODEL_TYPE; i < MODEL_TYPE_COUNT; ++i) {
     std::string model_type;