Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23890025: WIP (Introduce WTF::NonNullPtr<T>.) (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 2 months ago
Reviewers:
CC:
blink-reviews, shans, webcomponents-bugzilla_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, loislo+blink_chromium.org, Steve Block, dino_apple.com, alancutter (OOO until 2018), dglazkov+blink, abarth-chromium, dstockwell, Timothy Loh, jchaffraix+rendering, Eric Willigers, rjwright, dmazzoni, darktears, aboxhall, leviw+renderwatch, blink-layers+watch_chromium.org, Mike Lawther (Google), f(malita), Stephen Chennney, jeez
Visibility:
Public.

Description

Introduce WTF::NonNullPtr<T>. It stores a non-NULL T pointer. This experimental CL converts - Node::treeScope() return type from TreeScope& to NonNullPtr<TreeScope> - Frame::animation() return type from AnimationController* to NonNullPtr<AnimationController> BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -196 lines) Patch
M Source/core/accessibility/AccessibilityNodeObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 10 chunks +17 lines, -17 lines 0 comments Download
M Source/core/dom/EventContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventRetargeter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventRetargeter.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/dom/Node.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/StyleSheetCollections.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleSheetCollections.cpp View 6 chunks +27 lines, -27 lines 0 comments Download
M Source/core/dom/TreeScope.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScope.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/TreeScopeAdopter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScopeAdopter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDataListElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/FocusController.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/page/FocusController.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/page/Frame.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/page/Frame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 3 chunks +3 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 6 chunks +8 lines, -20 lines 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/Forward.h View 2 chunks +2 lines, -0 lines 0 comments Download
A Source/wtf/NonNullPtr.h View 1 chunk +39 lines, -0 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
7 years, 2 months ago (2013-10-11 05:58:34 UTC) #1 
According to the vote result, we prefer references to such template.
Closing.

Powered by Google App Engine
This is Rietveld 408576698