Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: components/sync/device_info/local_device_info_provider_impl_unittest.cc

Issue 2388973002: [Sync] Removing duplicate includes, part 2. (Closed)
Patch Set: Update for Max's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/device_info/local_device_info_provider_impl_unittest.cc
diff --git a/components/sync/device_info/local_device_info_provider_unittest.cc b/components/sync/device_info/local_device_info_provider_impl_unittest.cc
similarity index 87%
rename from components/sync/device_info/local_device_info_provider_unittest.cc
rename to components/sync/device_info/local_device_info_provider_impl_unittest.cc
index cc2c2c36e77ecf5c51f5c0d6bddbda0089179f3c..39a864257fde3414069365f9058de846fc964884 100644
--- a/components/sync/device_info/local_device_info_provider_unittest.cc
+++ b/components/sync/device_info/local_device_info_provider_impl_unittest.cc
@@ -2,12 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "components/sync/device_info/local_device_info_provider_impl.h"
+
#include "base/bind.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "components/sync/base/get_session_name.h"
-#include "components/sync/device_info/local_device_info_provider_impl.h"
-#include "components/version_info/version_info.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace syncer {
@@ -15,10 +15,10 @@ namespace syncer {
const char kLocalDeviceGuid[] = "foo";
const char kSigninScopedDeviceId[] = "device_id";
-class LocalDeviceInfoProviderTest : public testing::Test {
+class LocalDeviceInfoProviderImplTest : public testing::Test {
public:
- LocalDeviceInfoProviderTest() : called_back_(false) {}
- ~LocalDeviceInfoProviderTest() override {}
+ LocalDeviceInfoProviderImplTest() : called_back_(false) {}
+ ~LocalDeviceInfoProviderImplTest() override {}
void SetUp() override {
provider_.reset(new LocalDeviceInfoProviderImpl(
@@ -45,7 +45,7 @@ class LocalDeviceInfoProviderTest : public testing::Test {
base::RunLoop run_loop;
std::unique_ptr<LocalDeviceInfoProvider::Subscription> subscription =
provider_->RegisterOnInitializedCallback(
- base::Bind(&LocalDeviceInfoProviderTest::QuitLoopOnInitialized,
+ base::Bind(&LocalDeviceInfoProviderImplTest::QuitLoopOnInitialized,
base::Unretained(this), &run_loop));
run_loop.Run();
}
@@ -68,7 +68,7 @@ class LocalDeviceInfoProviderTest : public testing::Test {
base::MessageLoop message_loop_;
};
-TEST_F(LocalDeviceInfoProviderTest, OnInitializedCallback) {
+TEST_F(LocalDeviceInfoProviderImplTest, OnInitializedCallback) {
ASSERT_FALSE(called_back_);
StartInitializeProvider();
ASSERT_FALSE(called_back_);
@@ -76,7 +76,7 @@ TEST_F(LocalDeviceInfoProviderTest, OnInitializedCallback) {
EXPECT_TRUE(called_back_);
}
-TEST_F(LocalDeviceInfoProviderTest, GetLocalDeviceInfo) {
+TEST_F(LocalDeviceInfoProviderImplTest, GetLocalDeviceInfo) {
ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
StartInitializeProvider();
ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
@@ -97,7 +97,7 @@ TEST_F(LocalDeviceInfoProviderTest, GetLocalDeviceInfo) {
ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
}
-TEST_F(LocalDeviceInfoProviderTest, GetLocalSyncCacheGUID) {
+TEST_F(LocalDeviceInfoProviderImplTest, GetLocalSyncCacheGUID) {
EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
StartInitializeProvider();
@@ -110,7 +110,7 @@ TEST_F(LocalDeviceInfoProviderTest, GetLocalSyncCacheGUID) {
EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
}
-TEST_F(LocalDeviceInfoProviderTest, InitClearRace) {
+TEST_F(LocalDeviceInfoProviderImplTest, InitClearRace) {
EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
StartInitializeProvider();
@@ -123,7 +123,7 @@ TEST_F(LocalDeviceInfoProviderTest, InitClearRace) {
EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
}
-TEST_F(LocalDeviceInfoProviderTest, InitClearInitRace) {
+TEST_F(LocalDeviceInfoProviderImplTest, InitClearInitRace) {
EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
StartInitializeProvider();
provider_->Clear();

Powered by Google App Engine
This is Rietveld 408576698