scripts/slave/recipe_modules/chromium_android/config.py - Issue 23889036: Refactor the way that TestApi works so that it is actually useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/config.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: once more... Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipe_modules/gclient/api.py » ('j') | scripts/slave/recipe_modules/raw_io/api.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_android/config.py

diff --git a/scripts/slave/recipe_modules/chromium_android/config.py b/scripts/slave/recipe_modules/chromium_android/config.py

index f787bed200c7b5667b4bc42eb73d786c6c0ca224..074e9d7f0edb1298a6f334e27dec87c173036b73 100644

--- a/scripts/slave/recipe_modules/chromium_android/config.py

+++ b/scripts/slave/recipe_modules/chromium_android/config.py

@@ -2,8 +2,8 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-from slave.recipe_configs_util import config_item_context, ConfigGroup

-from slave.recipe_configs_util import Dict, Single, Static

+from slave.recipe_config import config_item_context, ConfigGroup

+from slave.recipe_config import Dict, Single, Static

def BaseConfig(INTERNAL, REPO_NAME, REPO_URL, **_kwargs):

return ConfigGroup(

@@ -11,7 +11,6 @@ def BaseConfig(INTERNAL, REPO_NAME, REPO_URL, **_kwargs):

REPO_NAME = Static(REPO_NAME),

REPO_URL = Static(REPO_URL),

target_arch = Single(basestring, required=False, empty_val=''),

- custom_vars = Dict(value_type=basestring),

extra_env = Dict(value_type=(basestring,int,list)),

run_findbugs = Single(bool, required=False, empty_val=False),

run_lint = Single(bool, required=False, empty_val=False),