scripts/slave/recipe_modules/chromium_android/api.py - Issue 23889036: Refactor the way that TestApi works so that it is actually useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: once more... Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.py ('k') | scripts/slave/recipe_modules/chromium_android/config.py » ('j') | scripts/slave/recipe_modules/raw_io/api.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_android/api.py

diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py

index 9291c35ddd5737159b9de0c7f974d673e7d867a8..725597583df21188a5d47241afed29ca20169ee3 100644

--- a/scripts/slave/recipe_modules/chromium_android/api.py

+++ b/scripts/slave/recipe_modules/chromium_android/api.py

@@ -49,7 +49,6 @@ class AndroidApi(recipe_api.RecipeApi):

s = spec.solutions[0]

s.name = repo_name

s.url = repo_url

- s.custom_vars = self.c.custom_vars

s.custom_deps = gclient_custom_deps or {}

if revision:

s.revision = revision

@@ -132,7 +131,7 @@ class AndroidApi(recipe_api.RecipeApi):

# TODO(sivachandra): Disable subannottations after cleaning up

# tree_truth.sh.

yield self.m.step('tree truth steps',

- [self.m.path.checkout('build', 'tree_truth.sh'),

+ [self.m.path.checkout('build', 'tree_truth.sh'),

self.m.path.checkout()] + repos,

allow_subannottations=True)