Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Yeeeeaaaahhhhhh! Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index 8166eb34c2386148cfb74d3d85dc59bbdcf74545..172d98c35728ccc2385448d355f9abee26dc9b9d 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -33,7 +33,6 @@ class AndroidApi(recipe_api.RecipeApi):
s = spec.solutions[0]
s.name = repo_name
s.url = repo_url
- s.custom_vars = self.c.custom_vars
iannucci 2013/09/19 21:28:19 I took this out because it wasn't working (not sur
s.custom_deps = gclient_custom_deps or {}
if revision:
s.revision = revision
@@ -124,7 +123,7 @@ class AndroidApi(recipe_api.RecipeApi):
# TODO(sivachandra): Disable subannottations after cleaning up
# tree_truth.sh.
yield self.m.step('Tree Truth Steps',
- [self.m.path.checkout('build', 'tree_truth.sh'),
+ [self.m.path.checkout('build', 'tree_truth.sh'),
self.m.path.checkout()] + repos,
allow_subannottations=True)
@@ -141,7 +140,7 @@ class AndroidApi(recipe_api.RecipeApi):
['-b',
self.m.path.checkout(self.internal_dir, 'bin', 'findbugs_filter'),
'-o', 'com.google.android.apps.chrome.-,org.chromium.-'])
-
+
return self.m.step('findbugs_internal', cmd, env=self.env)
def checkdeps(self):
« no previous file with comments | « scripts/slave/recipe_modules/chromium/config.py ('k') | scripts/slave/recipe_modules/chromium_android/config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698