Refactor the way that TestApi works so that it is actually useful.

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from slave import recipe_api
 
 class AndroidApi(recipe_api.RecipeApi):
   def __init__(self, **kwargs):
     super(AndroidApi, self).__init__(**kwargs)
 
@@ skipping 15 matching lines @@
                     REPO_URL=repo_url,
                     BUILD_CONFIG=target)
 
     # TODO(sivachandra): Move the setting of the gclient spec below to an
     # internal config extension when they are supported by the recipe system.
     spec = self.m.gclient.make_config('android_bare')
     spec.target_os = ['android']
     s = spec.solutions[0]
     s.name = repo_name
     s.url = repo_url
-    s.custom_vars = self.c.custom_vars

[iannucci, 2013/09/19 21:28:19]

I took this out because it wasn't working (not sure how it was passing), and
it's also not used for anything.

     s.custom_deps = gclient_custom_deps or {}
     if revision:
       s.revision = revision
     else:
       s.revision = 'refs/remotes/origin/master'
 
     yield self.m.gclient.checkout(spec)
 
     # TODO(sivachandra): Manufacture gclient spec such that it contains "src"
     # solution + repo_name solution. Then checkout will be automatically
@@ skipping 70 matching lines @@
 
   def run_tree_truth(self, show_revisions=False):
     # TODO(sivachandra): The downstream ToT builder will require
     # 'Show Revisions' step.
     repos = ['src', 'src-internal']
     if self.c.REPO_NAME not in repos:
       repos.append(self.c.REPO_NAME)
     # TODO(sivachandra): Disable subannottations after cleaning up
     # tree_truth.sh.
     yield self.m.step('Tree Truth Steps',
-                      [self.m.path.checkout('build', 'tree_truth.sh'), 
+                      [self.m.path.checkout('build', 'tree_truth.sh'),
                        self.m.path.checkout()] + repos,
                       allow_subannottations=True)
 
   def runhooks(self):
     return self.m.gclient.runhooks(env=self.env)
 
   def compile(self, target='Debug'):
     return self.m.chromium.compile(env=self.env)
 
   def findbugs(self):
     cmd = [self.m.path.checkout('build', 'android', 'findbugs_diff.py')]
     if self.c.INTERNAL:
       cmd.extend(
           ['-b',
            self.m.path.checkout(self.internal_dir, 'bin', 'findbugs_filter'),
            '-o', 'com.google.android.apps.chrome.-,org.chromium.-'])
-           
+
       return self.m.step('findbugs_internal', cmd, env=self.env)
 
   def checkdeps(self):
     return self.m.step(
       'checkdeps',
       [self.m.path.checkout('tools', 'checkdeps', 'checkdeps.py'),
        '--root=%s' % self.internal_dir],
       env=self.env)
 
   def lint(self):
     if self.c.INTERNAL:
       return self.m.step(
           'lint',
           [self.m.path.checkout(self.internal_dir, 'bin', 'lint.py')],
           env=self.env)