Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issue 2388903003: Stop testBlockNetworkLoadsWithAudio failing on low-end devices. (Closed)

Created:
4 years, 2 months ago by Tobias Sargeant
Modified:
4 years ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop testBlockNetworkLoadsWithAudio failing on low-end devices. This test was broken by https://codereview.chromium.org/2344353003 which disables autoplay on low-end devices. Instead of relying on that, use a button click to start playback. BUG=652389 Committed: https://crrev.com/a22b73c3566b9ff5b7743b4ddddabf65c20262df Cr-Commit-Position: refs/heads/master@{#422804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Tobias Sargeant
4 years, 2 months ago (2016-10-04 13:23:49 UTC) #2
Torne
lgtm
4 years, 2 months ago (2016-10-04 14:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388903003/1
4 years, 2 months ago (2016-10-04 15:01:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 15:23:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a22b73c3566b9ff5b7743b4ddddabf65c20262df Cr-Commit-Position: refs/heads/master@{#422804}
4 years, 2 months ago (2016-10-04 15:25:13 UTC) #8
whywhat
4 years, 2 months ago (2016-10-05 21:20:42 UTC) #9
Message was sent while issue was closed.
On 2016/10/04 at 15:25:13, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/a22b73c3566b9ff5b7743b4ddddabf65c20262df
> Cr-Commit-Position: refs/heads/master@{#422804}

Hm. Did AW allow autoplay before (compared to Clank)? I doubt we should disable
it then (this will break AW clients relying on autoplay on low end devices, no?)

Powered by Google App Engine
This is Rietveld 408576698