android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 2388903003: Stop testBlockNetworkLoadsWithAudio failing on low-end devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 2388903003: Stop testBlockNetworkLoadsWithAudio failing on low-end devices. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index 0adc75627823495b7e9aff651559e9bbdc547adb..04210b46e9db4f181be447ee3a7c63a98644694c 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -36,6 +36,7 @@ import org.chromium.base.test.util.RetryOnFailure;

import org.chromium.base.test.util.TestFileUtil;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.content.browser.test.util.CallbackHelper;

+import org.chromium.content.browser.test.util.DOMUtils;

import org.chromium.content.browser.test.util.HistoryUtils;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer;

import org.chromium.content_public.browser.WebContents;

@@ -2096,9 +2097,12 @@ public class AwSettingsTest extends AwTestBase {

// to know whether Url is accessed.

final String audioUrl = webServer.setResponse(httpPath, "1", null);

- String pageHtml = "<html><body><audio controls src='" + audioUrl + "' "

+ String pageHtml = "<html><body><audio id=\"audio\" controls src='" + audioUrl + "' "

+ "oncanplay=\"AudioEvent.onCanPlay();\" "

- + "onerror=\"AudioEvent.onError();\" /> </body></html>";

+ + "onerror=\"AudioEvent.onError();\"></audio>"

+ + "<button id=\"play\""

+ + "onclick=\"document.getElementById('audio').play();\"></button>"

+ + "</body></html>";

// Actual test. Blocking should trigger onerror handler.

awSettings.setBlockNetworkLoads(true);

runTestOnUiThread(new Runnable() {

@@ -2110,6 +2114,7 @@ public class AwSettingsTest extends AwTestBase {

int count = callback.getCallCount();

loadDataSync(awContents, contentClient.getOnPageFinishedHelper(), pageHtml,

"text/html", false);

+ DOMUtils.clickNode(this, testContainer.getContentViewCore(), "play");

callback.waitForCallback(count, 1);

assertEquals(0, webServer.getRequestCount(httpPath));

« no previous file with comments | « no previous file | no next file » | no next file with comments »